Re: [Intel-gfx] [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-13 Thread Sharma, Shashank
On 7/13/2017 7:40 PM, Ville Syrjälä wrote: What I mean is for_each() { ... + if (420) { + if (!420_dc) + return false; + } else { if (!444_dc) return false; + } } Got it, Thanks !

Re: [Intel-gfx] [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-13 Thread Ville Syrjälä
On Thu, Jul 13, 2017 at 07:05:12PM +0530, Sharma, Shashank wrote: > On 7/13/2017 6:56 PM, Ville Syrjälä wrote: > > > We don't want breaks in the loop. It's meant to go through all the > > connectors for the crtc. Granted on modern platforms there can only be > > one, but IMO assuming that just mak

Re: [Intel-gfx] [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-13 Thread Sharma, Shashank
On 7/13/2017 6:56 PM, Ville Syrjälä wrote: We don't want breaks in the loop. It's meant to go through all the connectors for the crtc. Granted on modern platforms there can only be one, but IMO assuming that just makes the whole thing look confusing. It's much clearer IMO if we do if (420) {

Re: [Intel-gfx] [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-13 Thread Ville Syrjälä
On Thu, Jul 13, 2017 at 06:31:25PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 7/13/2017 6:23 PM, Ville Syrjälä wrote: > > On Thu, Jul 13, 2017 at 10:56:06AM +0530, Sharma, Shashank wrote: > >> Regards > >> > >> Shashank > >> > >> > >> On 7/12/2017 10:47 PM, Ville Syrjälä wrot

Re: [Intel-gfx] [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-13 Thread Sharma, Shashank
Regards Shashank On 7/13/2017 6:23 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:56:06AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:38PM +0530, Shashank Sharma wrote: This patch checks encoder level supp

Re: [Intel-gfx] [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-13 Thread Ville Syrjälä
On Thu, Jul 13, 2017 at 10:56:06AM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 7/12/2017 10:47 PM, Ville Syrjälä wrote: > > On Mon, Jul 10, 2017 at 04:48:38PM +0530, Shashank Sharma wrote: > >> This patch checks encoder level support for YCBCR420 outputs. > >> The logic goes a

Re: [Intel-gfx] [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-12 Thread Sharma, Shashank
Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:38PM +0530, Shashank Sharma wrote: This patch checks encoder level support for YCBCR420 outputs. The logic goes as simple as this: If the input mode is YCBCR420-only mode: prepare HDMI for YCBCR420 outp

Re: [Intel-gfx] [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-12 Thread Ville Syrjälä
On Mon, Jul 10, 2017 at 04:48:38PM +0530, Shashank Sharma wrote: > This patch checks encoder level support for YCBCR420 outputs. > The logic goes as simple as this: > If the input mode is YCBCR420-only mode: prepare HDMI for > YCBCR420 output, else continue with RGB output mode. > > It checks if t

[Intel-gfx] [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-10 Thread Shashank Sharma
This patch checks encoder level support for YCBCR420 outputs. The logic goes as simple as this: If the input mode is YCBCR420-only mode: prepare HDMI for YCBCR420 output, else continue with RGB output mode. It checks if the mode is YCBCR420 and source can support this output then it marks the ycbc