Re: [Intel-gfx] [PATCH 10/13 v2] drm/i915: Needs_dmar, not

2013-01-17 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Wed, Jan 16, 2013 at 4:22 PM, Ben Widawsky wrote: > The reasoning behind our code taking two paths depending upon whether or > not we may have been configured for IOMMU isn't clear to me. It should > always be safe to use the pci mapping functions as they are designe

[Intel-gfx] [PATCH 10/13 v2] drm/i915: Needs_dmar, not

2013-01-16 Thread Ben Widawsky
The reasoning behind our code taking two paths depending upon whether or not we may have been configured for IOMMU isn't clear to me. It should always be safe to use the pci mapping functions as they are designed to abstract the decision we were handling in i915. Aside from simpler code, removing