Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Daniel Vetter
On Tue, Sep 17, 2013 at 1:02 PM, Ville Syrjälä wrote: > > But the problem is that addfb2 can't supply more than 4. So we need a new > ioctl if we want to collect all that information inside a single drm_fb > object. If we do add another ioctl then I think we should go at least to > 16, since we mi

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Daniel Vetter
On Tue, Sep 17, 2013 at 3:20 PM, Damien Lespiau wrote: > On Tue, Sep 17, 2013 at 12:37:48PM +0200, Daniel Vetter wrote: >> I guess we should start to check that. For 3d framebuffers with 2 >> separate buffer handles for each plane I think we need to add another flag >> to addfb2, e.g. >> >> #defin

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2013 at 02:20:41PM +0100, Damien Lespiau wrote: > On Tue, Sep 17, 2013 at 12:37:48PM +0200, Daniel Vetter wrote: > > I guess we should start to check that. For 3d framebuffers with 2 > > separate buffer handles for each plane I think we need to add another flag > > to addfb2, e.g. >

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Damien Lespiau
On Tue, Sep 17, 2013 at 12:37:48PM +0200, Daniel Vetter wrote: > I guess we should start to check that. For 3d framebuffers with 2 > separate buffer handles for each plane I think we need to add another flag > to addfb2, e.g. > > #define DRM_MODE_FB_3D_2_FRAMES (1<<1) /* separate left/right buffer

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2013 at 12:37:48PM +0200, Daniel Vetter wrote: > On Tue, Sep 17, 2013 at 12:54:09PM +0300, Ville Syrjälä wrote: > > On Tue, Sep 17, 2013 at 10:03:12AM +0100, Damien Lespiau wrote: > > > On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrjälä wrote: > > > > +++ b/drivers/gpu/drm/drm

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Daniel Vetter
On Tue, Sep 17, 2013 at 12:54:09PM +0300, Ville Syrjälä wrote: > On Tue, Sep 17, 2013 at 10:03:12AM +0100, Damien Lespiau wrote: > > On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrjälä wrote: > > > +++ b/drivers/gpu/drm/drm_crtc.c > > > > @@ -2131,6 +2131,17 @@ int drm_mode_setcrtc(struct drm_

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2013 at 10:03:12AM +0100, Damien Lespiau wrote: > On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrjälä wrote: > > +++ b/drivers/gpu/drm/drm_crtc.c > > > @@ -2131,6 +2131,17 @@ int drm_mode_setcrtc(struct drm_device *dev, void > > > *data, > > > goto out; > > >

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Damien Lespiau
On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrjälä wrote: > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -2131,6 +2131,17 @@ int drm_mode_setcrtc(struct drm_device *dev, void > > *data, > > goto out; > > } > > > > + /* > > +* Do not allow th

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Ville Syrjälä
On Mon, Sep 16, 2013 at 06:48:53PM +0100, Damien Lespiau wrote: > There are a few things to be flushed out if we want to allow multiple > buffers stereo framebuffers: > - What with drm_planes? what semantics do they follow, what is the > hardware able to do with them? > - How do we define w

[Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-16 Thread Damien Lespiau
There are a few things to be flushed out if we want to allow multiple buffers stereo framebuffers: - What with drm_planes? what semantics do they follow, what is the hardware able to do with them? - How do we define which buffer if the right/left one - Do we allow flips between 1 buffer f