Re: [Intel-gfx] [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion

2013-04-02 Thread Jesse Barnes
On Tue, 2 Apr 2013 13:47:52 -0700 Jesse Barnes wrote: > On Thu, 28 Mar 2013 10:41:56 +0100 > Daniel Vetter wrote: > > > > > + /* DP has a bunch of special case unfortunately, so mark the pipe > > +* accordingly. */ > > + bool has_dp_encoder; > > Looks pretty good, but I don't think t

Re: [Intel-gfx] [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion

2013-04-02 Thread Jesse Barnes
On Thu, 28 Mar 2013 10:41:56 +0100 Daniel Vetter wrote: > > + /* DP has a bunch of special case unfortunately, so mark the pipe > + * accordingly. */ > + bool has_dp_encoder; Looks pretty good, but I don't think this field is used anywhere? Maybe it belongs in a later patch? Also

[Intel-gfx] [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion

2013-03-28 Thread Daniel Vetter
There's a rather decent confusion going on around transcoder m_n values. So let's clarify: - All dp encoders need this, either on the pch transcoder if it's a pch port, or on the cpu transcoder/pipe if it's a cpu port. - fdi links need to have the right m_n values for the fdi link set in the cp

[Intel-gfx] [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion

2013-02-21 Thread Daniel Vetter
There's a rather decent confusion going on around transcoder m_n values. So let's clarify: - All dp encoders need this, either on the pch transcoder if it's a pch port, or on the cpu transcoder/pipe if it's a cpu port. - fdi links need to have the right m_n values for the fdi link set in the cp

[Intel-gfx] [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion

2013-02-21 Thread Daniel Vetter
There's a rather decent confusion going on around transcoder m_n values. So let's clarify: - All dp encoders need this, either on the pch transcoder if it's a pch port, or on the cpu transcoder/pipe if it's a cpu port. - fdi links need to have the right m_n values for the fdi link set in the cp