[Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

2013-09-11 Thread Ben Widawsky
lifted from Daniel: pread/pwrite isn't about the object's domain at all, but purely about synchronizing for outstanding rendering. Replacing the call to set_to_gtt_domain with a wait_rendering would imo improve code readability. Furthermore we could pimp pread to only block for outstanding writes a

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

2013-09-03 Thread Ben Widawsky
On Tue, Sep 03, 2013 at 06:08:19PM +0200, Daniel Vetter wrote: > On Mon, Sep 02, 2013 at 04:12:36PM +0200, Daniel Vetter wrote: > > On Mon, Sep 02, 2013 at 02:14:12PM +0100, Chris Wilson wrote: > > > On Mon, Sep 02, 2013 at 08:32:24AM +0200, Daniel Vetter wrote: > > > > On Fri, Aug 30, 2013 at 08:3

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

2013-09-03 Thread Daniel Vetter
On Mon, Sep 02, 2013 at 04:12:36PM +0200, Daniel Vetter wrote: > On Mon, Sep 02, 2013 at 02:14:12PM +0100, Chris Wilson wrote: > > On Mon, Sep 02, 2013 at 08:32:24AM +0200, Daniel Vetter wrote: > > > On Fri, Aug 30, 2013 at 08:39:46PM -0700, Ben Widawsky wrote: > > > > On Sat, Aug 31, 2013 at 12:50

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

2013-09-02 Thread Daniel Vetter
On Mon, Sep 02, 2013 at 02:14:12PM +0100, Chris Wilson wrote: > On Mon, Sep 02, 2013 at 08:32:24AM +0200, Daniel Vetter wrote: > > On Fri, Aug 30, 2013 at 08:39:46PM -0700, Ben Widawsky wrote: > > > On Sat, Aug 31, 2013 at 12:50:30AM +0100, Chris Wilson wrote: > > > > On Fri, Aug 30, 2013 at 04:43:

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

2013-09-02 Thread Chris Wilson
On Mon, Sep 02, 2013 at 08:32:24AM +0200, Daniel Vetter wrote: > On Fri, Aug 30, 2013 at 08:39:46PM -0700, Ben Widawsky wrote: > > On Sat, Aug 31, 2013 at 12:50:30AM +0100, Chris Wilson wrote: > > > On Fri, Aug 30, 2013 at 04:43:54PM -0700, Ben Widawsky wrote: > > > > lifted from Daniel: > > > > pr

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

2013-09-01 Thread Daniel Vetter
On Fri, Aug 30, 2013 at 08:39:46PM -0700, Ben Widawsky wrote: > On Sat, Aug 31, 2013 at 12:50:30AM +0100, Chris Wilson wrote: > > On Fri, Aug 30, 2013 at 04:43:54PM -0700, Ben Widawsky wrote: > > > lifted from Daniel: > > > pread/pwrite isn't about the object's domain at all, but purely about > > >

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

2013-08-30 Thread Ben Widawsky
On Sat, Aug 31, 2013 at 12:50:30AM +0100, Chris Wilson wrote: > On Fri, Aug 30, 2013 at 04:43:54PM -0700, Ben Widawsky wrote: > > lifted from Daniel: > > pread/pwrite isn't about the object's domain at all, but purely about > > synchronizing for outstanding rendering. Replacing the call to > > set_

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

2013-08-30 Thread Chris Wilson
On Fri, Aug 30, 2013 at 04:43:54PM -0700, Ben Widawsky wrote: > lifted from Daniel: > pread/pwrite isn't about the object's domain at all, but purely about > synchronizing for outstanding rendering. Replacing the call to > set_to_gtt_domain with a wait_rendering would imo improve code > readability

[Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

2013-08-30 Thread Ben Widawsky
lifted from Daniel: pread/pwrite isn't about the object's domain at all, but purely about synchronizing for outstanding rendering. Replacing the call to set_to_gtt_domain with a wait_rendering would imo improve code readability. Furthermore we could pimp pread to only block for outstanding writes a