Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-08-02 Thread Jason Ekstrand
The userspace mesa patches to produce Y_TILED_CCS surfaces have been reviewed for a couple of weeks now. So long as kmscube counts as userspace, I think this should be good to land. Acked-by: Jason Ekstrand On Mon, Jul 31, 2017 at 12:04 AM, Vidya Srinivas wrote: > From: Ville Syrjälä > > SKL

[Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-07-30 Thread Vidya Srinivas
From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are compressed and which are not. The lo

[Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-07-23 Thread Vidya Srinivas
From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are compressed and which are not. The lo

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-07-14 Thread Jason Ekstrand
FYI: The latest version of the CCS modifier patches for mesa are now reviewed: https://patchwork.freedesktop.org/series/27213/ I'll be landing the prep-work patches soon. The final couple of patches are just waiting on the I915_FORMAT_MOD_Y_TILED_CCS in drm_fourcc.h to land in the kernel. On S

[Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-07-11 Thread Vidya Srinivas
From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are compressed and which are not. The lo

[Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-07-09 Thread Vidya Srinivas
From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are compressed and which are not. The lo

[Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-06-19 Thread Vidya Srinivas
From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are compressed and which are not. The lo

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-06-07 Thread Daniel Stone
Hi, On 7 June 2017 at 17:28, Ville Syrjälä wrote: > On Wed, Jun 07, 2017 at 04:48:06PM +0100, Daniel Stone wrote: >> It does, and I have correct CCS output (tested by displaying frames >> either as Y_CCS, or as plain Y; correct display with the former and >> visibly showing an incomplete primary

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-06-07 Thread Ville Syrjälä
On Wed, Jun 07, 2017 at 04:48:06PM +0100, Daniel Stone wrote: > Hi, > > On 7 June 2017 at 16:33, Ville Syrjälä wrote: > > On Wed, Jun 07, 2017 at 03:24:58PM +0100, Daniel Stone wrote: > >> On 7 June 2017 at 13:53, Ville Syrjälä > >> wrote: > >> > Anyways, I'll have to revisit the the offsets[]

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-06-07 Thread Daniel Stone
Hi, On 7 June 2017 at 16:33, Ville Syrjälä wrote: > On Wed, Jun 07, 2017 at 03:24:58PM +0100, Daniel Stone wrote: >> On 7 June 2017 at 13:53, Ville Syrjälä wrote: >> > Anyways, I'll have to revisit the the offsets[] thing because people >> > didn't like my original linear offset idea, and it doe

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-06-07 Thread Ville Syrjälä
On Wed, Jun 07, 2017 at 03:24:58PM +0100, Daniel Stone wrote: > Hi, > > On 7 June 2017 at 13:53, Ville Syrjälä wrote: > > On Wed, Jun 07, 2017 at 12:44:47PM +0100, Daniel Stone wrote: > >> /* > >> * We don't require any > >> * CCS block size alignment of the fb under the assumption that the > >

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-06-07 Thread Daniel Stone
Hi, On 7 June 2017 at 13:53, Ville Syrjälä wrote: > On Wed, Jun 07, 2017 at 12:44:47PM +0100, Daniel Stone wrote: >> /* >> * We don't require any >> * CCS block size alignment of the fb under the assumption that the >> * hardware will handle things correctly of only a single pixel >> * gets t

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-06-07 Thread Ville Syrjälä
On Wed, Jun 07, 2017 at 12:44:47PM +0100, Daniel Stone wrote: > Hi Vidya, > > On 7 June 2017 at 12:40, Vidya Srinivas wrote: > > +static const struct drm_format_info ccs_formats[] = { > > + { .format = DRM_FORMAT_XRGB, .depth = 24, .num_planes = 2, .cpp > > = { 4, 1, }, .hsub = 16, .vs

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-06-07 Thread Daniel Stone
Hi Vidya, On 7 June 2017 at 12:40, Vidya Srinivas wrote: > +static const struct drm_format_info ccs_formats[] = { > + { .format = DRM_FORMAT_XRGB, .depth = 24, .num_planes = 2, .cpp = > { 4, 1, }, .hsub = 16, .vsub = 8, }, > + { .format = DRM_FORMAT_XBGR, .depth = 24, .num_pl

[Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-06-07 Thread Vidya Srinivas
From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are compressed and which are not. The lo