Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-10-27 Thread Rodrigo Vivi
quires lot of code refactoring. > > > > Or Is there any way we follow 1) with less code refactoring.? > > > > Or Do you think there is any other proper approach ? > > > > > > > > (Please note rev3 is not clean, d3cold off support need to be > &

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-10-27 Thread Rodrigo Vivi
+Rafael On Thu, Jul 21, 2022 at 03:29:48PM +0530, tilak.tang...@intel.com wrote: > From: Tilak Tangudu > > Added is_intel_rpm_allowed function to query the runtime_pm > status and disllow during suspending and resuming. > > v2: Return -2 if runtime pm is not allowed in runtime_pm_get > and sk

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-09-28 Thread Gupta, Anshuman
> > > > (Please note rev3 is not clean, d3cold off support need to be > > > restricted to Headless clients for now , we see some Display related > > > warnings in headed case ). > > I believe this warnings shows that the solution 2 has some flaws or corner > c

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-09-28 Thread Vivi, Rodrigo
Headless clients for now , we see some Display related warnings in > > headed > > case ). I believe this warnings shows that the solution 2 has some flaws or corner cases that we don't fully understand. I honestly believe we need to go with option 1, moving the runtime_pm_

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-09-28 Thread Tangudu, Tilak
ires lot of code refactoring. > Or Is there any way we follow 1) with less code refactoring.? > Or Do you think there is any other proper approach ? > > (Please note rev3 is not clean, d3cold off support need to be restricted to > Headless clients for now , we see some Dis

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-09-28 Thread Tangudu, Tilak
v3 is not clean, d3cold off support need to be restricted to Headless clients for now , we see some Display related warnings in headed case ). Thanks Tilak > -Original Message----- > From: Intel-gfx On Behalf Of > Tangudu, Tilak > Sent: Thursday, August 4, 2022 11:03 AM > To: Vivi,

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-08-04 Thread Vivi, Rodrigo
On Thu, 2022-08-04 at 05:32 +, Tangudu, Tilak wrote: > > > > -Original Message- > > From: Vivi, Rodrigo > > Sent: Thursday, August 4, 2022 2:01 AM > > To: Tangudu, Tilak > > Cc: Ewins, Jon ; Belgaumkar, Vinay > > ; Roper, Matthew D > > ; Wilson, Chris P > > ; > > Nikula, Jani ; Gupt

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-08-03 Thread Gupta, Anshuman
> -Original Message- > From: Tangudu, Tilak > Sent: Thursday, July 21, 2022 3:30 PM > To: Ewins, Jon ; Belgaumkar, Vinay > ; Roper, Matthew D > ; Wilson, Chris P ; > Nikula, Jani ; Gupta, saurabhg > ; Vivi, Rodrigo ; Gupta, > Anshuman ; Nilawar, Badal > ; Tangudu, Tilak ; Deak, > Imre ;

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-08-03 Thread Tangudu, Tilak
> -Original Message- > From: Vivi, Rodrigo > Sent: Thursday, August 4, 2022 2:01 AM > To: Tangudu, Tilak > Cc: Ewins, Jon ; Belgaumkar, Vinay > ; Roper, Matthew D > ; Wilson, Chris P ; > Nikula, Jani ; Gupta, saurabhg > ; Gupta, Anshuman > ; Nilawar, Badal ; > Deak, Imre ; Iddamsetty,

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-08-03 Thread Rodrigo Vivi
On Thu, Jul 21, 2022 at 03:29:48PM +0530, tilak.tang...@intel.com wrote: > From: Tilak Tangudu > > Added is_intel_rpm_allowed function to query the runtime_pm > status and disllow during suspending and resuming. > > v2: Return -2 if runtime pm is not allowed in runtime_pm_get > and skip wakeref

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-07-24 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/tilak-tangudu-intel-com/drm-i915-Add-D3Cold-Off-support-for-runtime-pm/20220721-174913 base: git://anongit.freedesktop.org/drm/drm-tip drm-t

[Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-07-21 Thread tilak . tangudu
From: Tilak Tangudu Added is_intel_rpm_allowed function to query the runtime_pm status and disllow during suspending and resuming. v2: Return -2 if runtime pm is not allowed in runtime_pm_get and skip wakeref release in runtime_pm_put if wakeref value is -2. - Jani N Signed-off-by: Tilak Tangudu