Re: [Intel-gfx] [PATCH 1/6] drm/i915: hangcheck robustification

2011-10-19 Thread Chris Wilson
On Wed, 19 Oct 2011 08:02:57 -0700, Ben Widawsky wrote: > On Wed, 19 Oct 2011 12:32:25 +0100 > Chris Wilson wrote: > > NAK: This failed to detect a hang, leaving my box frozen. I suspect that > > the value of INSTDONE was fluctuating on the render ring even though we > > had now requests pending

Re: [Intel-gfx] [PATCH 1/6] drm/i915: hangcheck robustification

2011-10-19 Thread Ben Widawsky
On Wed, 19 Oct 2011 12:32:25 +0100 Chris Wilson wrote: > On Tue, 11 Oct 2011 16:39:09 +0200, Daniel Vetter > wrote: > > From: Ben Widawsky > > > > This was pulled out of the per ring error handling patch series as it > > actually fixes two issues, and bikeshedding appears to be going on > > t

Re: [Intel-gfx] [PATCH 1/6] drm/i915: hangcheck robustification

2011-10-19 Thread Chris Wilson
On Tue, 11 Oct 2011 16:39:09 +0200, Daniel Vetter wrote: > From: Ben Widawsky > > This was pulled out of the per ring error handling patch series as it > actually fixes two issues, and bikeshedding appears to be going on > there. > > First, remove setting hangcheck_count when we do notify ring

[Intel-gfx] [PATCH 1/6] drm/i915: hangcheck robustification

2011-10-11 Thread Daniel Vetter
From: Ben Widawsky This was pulled out of the per ring error handling patch series as it actually fixes two issues, and bikeshedding appears to be going on there. First, remove setting hangcheck_count when we do notify ring. While it seems counterintuitive to be setting up a timer to catch hangc