Re: [Intel-gfx] [PATCH 1/6] RFCish: write only mappings (aka non-blocking)

2011-09-21 Thread Daniel Vetter
On Tue, Sep 20, 2011 at 03:19:53PM -0700, Ben Widawsky wrote: > On Tue, 20 Sep 2011 13:06:43 +0200 > Daniel Vetter wrote: > > - I'm sorry having suggested to implement the clflush ioctl, I think > > it's a foolish idea, now. Non-blocking mmaps is a performance > > optimization, needing to sync cac

Re: [Intel-gfx] [PATCH 1/6] RFCish: write only mappings (aka non-blocking)

2011-09-21 Thread Daniel Vetter
On Tue, Sep 20, 2011 at 10:16:39PM +0100, Chris Wilson wrote: > On Tue, 20 Sep 2011 13:06:43 +0200, Daniel Vetter wrote: > > Now non-blocking cpu mmaps make very much sense on llc/snooped buffer > > objects. So I think we actually need an ioctl to get obj->cache_level so > > userspace can de

Re: [Intel-gfx] [PATCH 1/6] RFCish: write only mappings (aka non-blocking)

2011-09-20 Thread Ben Widawsky
On Tue, 20 Sep 2011 13:06:43 +0200 Daniel Vetter wrote: > On Mon, Sep 19, 2011 at 09:25:00PM -0700, Ben Widawsky wrote: > > I'm going to keep this short... > > Patch 5 is my test case. > > On Gen6 I see slightly better performance. On Gen5 I see really > > really improvements (like 3x) for non GT

Re: [Intel-gfx] [PATCH 1/6] RFCish: write only mappings (aka non-blocking)

2011-09-20 Thread Chris Wilson
On Tue, 20 Sep 2011 13:06:43 +0200, Daniel Vetter wrote: > Now non-blocking cpu mmaps make very much sense on llc/snooped buffer > objects. So I think we actually need an ioctl to get obj->cache_level so > userspace can decide whether it should use non-blocking gtt mmaps or cpu > (non-bloc

Re: [Intel-gfx] [PATCH 1/6] RFCish: write only mappings (aka non-blocking)

2011-09-20 Thread Daniel Vetter
On Tue, Sep 20, 2011 at 10:17:25AM -0700, Eric Anholt wrote: > On Tue, 20 Sep 2011 13:06:43 +0200, Daniel Vetter wrote: > > - Why do we need any patches for gtt non-blocking mmaps? I've re-read our > > code, and afaics we're only calling wait_rendering from gem_fault if > > obj->gtt_space == N

Re: [Intel-gfx] [PATCH 1/6] RFCish: write only mappings (aka non-blocking)

2011-09-20 Thread Eric Anholt
On Tue, 20 Sep 2011 13:06:43 +0200, Daniel Vetter wrote: > - Why do we need any patches for gtt non-blocking mmaps? I've re-read our > code, and afaics we're only calling wait_rendering from gem_fault if > obj->gtt_space == NULL. I.e. there's no way the gpu is currently using > the data and

Re: [Intel-gfx] [PATCH 1/6] RFCish: write only mappings (aka non-blocking)

2011-09-20 Thread Daniel Vetter
On Mon, Sep 19, 2011 at 09:25:00PM -0700, Ben Widawsky wrote: > I'm going to keep this short... > Patch 5 is my test case. > On Gen6 I see slightly better performance. On Gen5 I see really really > improvements (like 3x) for non GTT write only maps over regular mmaps. > GTT mappings don't really sh

[Intel-gfx] [PATCH 1/6] RFCish: write only mappings (aka non-blocking)

2011-09-19 Thread Ben Widawsky
I'm going to keep this short... Patch 5 is my test case. On Gen6 I see slightly better performance. On Gen5 I see really really improvements (like 3x) for non GTT write only maps over regular mmaps. GTT mappings don't really show any improvements as a whole. Better tests would be nice, but without