Re: [Intel-gfx] [PATCH 1/5] drm/i915/icl: use tc_port in MG_PLL macros

2019-01-24 Thread Paulo Zanoni
Em qui, 2019-01-24 às 10:52 -0800, Lucas De Marchi escreveu: > On Wed, Jan 23, 2019 at 05:15:26PM -0800, Paulo Zanoni wrote: > > Em qui, 2019-01-17 às 12:21 -0800, Lucas De Marchi escreveu: > > > Fix the TODO leftover in the code by changing the argument in MG_PLL > > > macros. The MG_PLL ids used

Re: [Intel-gfx] [PATCH 1/5] drm/i915/icl: use tc_port in MG_PLL macros

2019-01-24 Thread Lucas De Marchi
On Wed, Jan 23, 2019 at 05:15:26PM -0800, Paulo Zanoni wrote: Em qui, 2019-01-17 às 12:21 -0800, Lucas De Marchi escreveu: Fix the TODO leftover in the code by changing the argument in MG_PLL macros. The MG_PLL ids used to access the register values can be converted from tc_port rather than port

Re: [Intel-gfx] [PATCH 1/5] drm/i915/icl: use tc_port in MG_PLL macros

2019-01-23 Thread Paulo Zanoni
Em qui, 2019-01-17 às 12:21 -0800, Lucas De Marchi escreveu: > Fix the TODO leftover in the code by changing the argument in MG_PLL > macros. The MG_PLL ids used to access the register values can be > converted from tc_port rather than port. > An explanation on why the new model is better would b

[Intel-gfx] [PATCH 1/5] drm/i915/icl: use tc_port in MG_PLL macros

2019-01-17 Thread Lucas De Marchi
Fix the TODO leftover in the code by changing the argument in MG_PLL macros. The MG_PLL ids used to access the register values can be converted from tc_port rather than port. The helper functions were also renamed to use "tc" as prefix to make them more generic. Signed-off-by: Lucas De Marchi --