Re: [Intel-gfx] [PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers

2020-01-17 Thread Mikita Lipski
Thanks for the catch! Makes sense to skip disabled managers there, but I wonder why it didn't cause a crash with amdgpu. Anyways looks good to me. Acked-by: Mikita Lipski On 1/16/20 8:58 PM, José Roberto de Souza wrote: When a main MST port is disconnected drivers should call drm_dp_mst_topol

Re: [Intel-gfx] [PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers

2020-01-17 Thread Alex Deucher
On Fri, Jan 17, 2020 at 3:21 PM Lyude Paul wrote: > > Reviewed-by: Lyude Paul > Applied. I'll send a PR shortly. Thanks! Alex > On Thu, 2020-01-16 at 17:58 -0800, José Roberto de Souza wrote: > > When a main MST port is disconnected drivers should call > > drm_dp_mst_topology_mgr_set_mst() d

Re: [Intel-gfx] [PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers

2020-01-17 Thread Lyude Paul
Reviewed-by: Lyude Paul On Thu, 2020-01-16 at 17:58 -0800, José Roberto de Souza wrote: > When a main MST port is disconnected drivers should call > drm_dp_mst_topology_mgr_set_mst() disabling the MST manager, this > function will set manager mst_primary to NULL and it will cause the > crash bell

[Intel-gfx] [PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers

2020-01-16 Thread José Roberto de Souza
When a main MST port is disconnected drivers should call drm_dp_mst_topology_mgr_set_mst() disabling the MST manager, this function will set manager mst_primary to NULL and it will cause the crash bellow on the next atomic check when trying to access mst_primary->port. As there is no use in runnin