Re: [Intel-gfx] [PATCH 1/4] drm/i915: save/restore the legacy backlight control

2012-08-30 Thread Daniel Vetter
On Thu, Aug 30, 2012 at 10:32:48AM +0200, Indan Zupancic wrote: > On Tue, August 28, 2012 17:15, Daniel Vetter wrote: > > On Tue, Aug 28, 2012 at 04:49:15PM +0200, Indan Zupancic wrote: > >> By the way, saving LBPC only makes sense if it's done before it was > >> set to 0 to disable the panel. I do

Re: [Intel-gfx] [PATCH 1/4] drm/i915: save/restore the legacy backlight control

2012-08-30 Thread Indan Zupancic
On Tue, August 28, 2012 17:15, Daniel Vetter wrote: > On Tue, Aug 28, 2012 at 04:49:15PM +0200, Indan Zupancic wrote: >> By the way, saving LBPC only makes sense if it's done before it was >> set to 0 to disable the panel. I don't know if the current code does >> the right thing, I haven't looked a

Re: [Intel-gfx] [PATCH 1/4] drm/i915: save/restore the legacy backlight control

2012-08-28 Thread Daniel Vetter
On Tue, Aug 28, 2012 at 04:49:15PM +0200, Indan Zupancic wrote: > On Tue, August 28, 2012 16:14, Daniel Vetter wrote: > > On Tue, Aug 28, 2012 at 03:56:31PM +0200, Indan Zupancic wrote: > >> Hello, > >> > >> On Tue, August 28, 2012 08:53, Jani Nikula wrote: > >> > From: Daniel Vetter > >> > > >> >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: save/restore the legacy backlight control

2012-08-28 Thread Indan Zupancic
On Tue, August 28, 2012 16:14, Daniel Vetter wrote: > On Tue, Aug 28, 2012 at 03:56:31PM +0200, Indan Zupancic wrote: >> Hello, >> >> On Tue, August 28, 2012 08:53, Jani Nikula wrote: >> > From: Daniel Vetter >> > >> > This is a prep patch to stop drm/i915 from changing the LBPC registers >> > its

Re: [Intel-gfx] [PATCH 1/4] drm/i915: save/restore the legacy backlight control

2012-08-28 Thread Daniel Vetter
On Tue, Aug 28, 2012 at 03:56:31PM +0200, Indan Zupancic wrote: > Hello, > > On Tue, August 28, 2012 08:53, Jani Nikula wrote: > > From: Daniel Vetter > > > > This is a prep patch to stop drm/i915 from changing the LBPC registers > > itself - but we still need to properly save/restore it on > > s

Re: [Intel-gfx] [PATCH 1/4] drm/i915: save/restore the legacy backlight control

2012-08-28 Thread Indan Zupancic
Hello, On Tue, August 28, 2012 08:53, Jani Nikula wrote: > From: Daniel Vetter > > This is a prep patch to stop drm/i915 from changing the LBPC registers > itself - but we still need to properly save/restore it on > suspend/resume. > > Signed-off-by: Daniel Vetter > Signed-off-by: Jani Nikula >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: save/restore the legacy backlight control

2012-08-28 Thread Daniel Vetter
On Tue, Aug 28, 2012 at 08:16:54AM +0100, Chris Wilson wrote: > On Tue, 28 Aug 2012 09:53:36 +0300, Jani Nikula wrote: > > From: Daniel Vetter > > > > This is a prep patch to stop drm/i915 from changing the LBPC registers > > itself - but we still need to properly save/restore it on > > suspend/

Re: [Intel-gfx] [PATCH 1/4] drm/i915: save/restore the legacy backlight control

2012-08-28 Thread Chris Wilson
On Tue, 28 Aug 2012 09:53:36 +0300, Jani Nikula wrote: > From: Daniel Vetter > > This is a prep patch to stop drm/i915 from changing the LBPC registers > itself - but we still need to properly save/restore it on > suspend/resume. My presumption was that there were BIOSes out there that only adj

[Intel-gfx] [PATCH 1/4] drm/i915: save/restore the legacy backlight control

2012-08-27 Thread Jani Nikula
From: Daniel Vetter This is a prep patch to stop drm/i915 from changing the LBPC registers itself - but we still need to properly save/restore it on suspend/resume. Signed-off-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/i