Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-14 Thread Nick Hoath
On 14/10/2015 15:42, Dave Gordon wrote: On 13/10/15 12:36, Chris Wilson wrote: On Tue, Oct 13, 2015 at 01:29:56PM +0200, Daniel Vetter wrote: On Fri, Oct 09, 2015 at 06:23:50PM +0100, Chris Wilson wrote: On Fri, Oct 09, 2015 at 07:18:21PM +0200, Daniel Vetter wrote: On Fri, Oct 09, 2015 at 10

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-14 Thread Dave Gordon
On 13/10/15 12:36, Chris Wilson wrote: On Tue, Oct 13, 2015 at 01:29:56PM +0200, Daniel Vetter wrote: On Fri, Oct 09, 2015 at 06:23:50PM +0100, Chris Wilson wrote: On Fri, Oct 09, 2015 at 07:18:21PM +0200, Daniel Vetter wrote: On Fri, Oct 09, 2015 at 10:45:35AM +0100, Chris Wilson wrote: On F

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-13 Thread Chris Wilson
On Tue, Oct 13, 2015 at 01:29:56PM +0200, Daniel Vetter wrote: > On Fri, Oct 09, 2015 at 06:23:50PM +0100, Chris Wilson wrote: > > On Fri, Oct 09, 2015 at 07:18:21PM +0200, Daniel Vetter wrote: > > > On Fri, Oct 09, 2015 at 10:45:35AM +0100, Chris Wilson wrote: > > > > On Fri, Oct 09, 2015 at 11:15

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-13 Thread Daniel Vetter
On Fri, Oct 09, 2015 at 06:23:50PM +0100, Chris Wilson wrote: > On Fri, Oct 09, 2015 at 07:18:21PM +0200, Daniel Vetter wrote: > > On Fri, Oct 09, 2015 at 10:45:35AM +0100, Chris Wilson wrote: > > > On Fri, Oct 09, 2015 at 11:15:08AM +0200, Daniel Vetter wrote: > > > > My idea was to create a new r

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-09 Thread Chris Wilson
On Fri, Oct 09, 2015 at 07:18:21PM +0200, Daniel Vetter wrote: > On Fri, Oct 09, 2015 at 10:45:35AM +0100, Chris Wilson wrote: > > On Fri, Oct 09, 2015 at 11:15:08AM +0200, Daniel Vetter wrote: > > > My idea was to create a new request for 3. which gets signalled by the > > > scheduler in intel_lrc

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-09 Thread Daniel Vetter
On Fri, Oct 09, 2015 at 10:45:35AM +0100, Chris Wilson wrote: > On Fri, Oct 09, 2015 at 11:15:08AM +0200, Daniel Vetter wrote: > > My idea was to create a new request for 3. which gets signalled by the > > scheduler in intel_lrc_irq_handler. My idea was that we'd only create > > these when a ctx sw

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-09 Thread Chris Wilson
On Fri, Oct 09, 2015 at 11:15:08AM +0200, Daniel Vetter wrote: > My idea was to create a new request for 3. which gets signalled by the > scheduler in intel_lrc_irq_handler. My idea was that we'd only create > these when a ctx switch might occur to avoid overhead, but I guess if we > just outright

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-09 Thread Daniel Vetter
On Fri, Oct 09, 2015 at 09:36:58AM +0100, Chris Wilson wrote: > On Fri, Oct 09, 2015 at 09:58:51AM +0200, Daniel Vetter wrote: > > > > +static bool i915_gem_request_retireable(struct drm_i915_gem_request > > > > *req) > > > > +{ > > > > + return (i915_gem_request_completed(req, true) && > >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-09 Thread Chris Wilson
On Fri, Oct 09, 2015 at 09:58:51AM +0200, Daniel Vetter wrote: > > > +static bool i915_gem_request_retireable(struct drm_i915_gem_request *req) > > > +{ > > > + return (i915_gem_request_completed(req, true) && > > > + (!req->elsp_submitted || req->ctx_complete)); > > > > I disagree with th

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-09 Thread Daniel Vetter
On Thu, Oct 08, 2015 at 01:32:07PM +0100, Chris Wilson wrote: > On Tue, Oct 06, 2015 at 03:52:01PM +0100, Nick Hoath wrote: > > There is a desire to simplify the i915 driver by reducing the number of > > different code paths introduced by the LRC / execlists support. As the > > execlists request i

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-08 Thread Chris Wilson
On Tue, Oct 06, 2015 at 03:52:01PM +0100, Nick Hoath wrote: > There is a desire to simplify the i915 driver by reducing the number of > different code paths introduced by the LRC / execlists support. As the > execlists request is now part of the gem request it is possible and > desirable to unify

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-07 Thread Chris Wilson
On Wed, Oct 07, 2015 at 06:03:48PM +0200, Daniel Vetter wrote: > On Tue, Oct 06, 2015 at 03:52:01PM +0100, Nick Hoath wrote: > > There is a desire to simplify the i915 driver by reducing the number of > > different code paths introduced by the LRC / execlists support. As the > > execlists request

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-07 Thread Daniel Vetter
On Tue, Oct 06, 2015 at 03:52:01PM +0100, Nick Hoath wrote: > There is a desire to simplify the i915 driver by reducing the number of > different code paths introduced by the LRC / execlists support. As the > execlists request is now part of the gem request it is possible and > desirable to unify

[Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-06 Thread Nick Hoath
There is a desire to simplify the i915 driver by reducing the number of different code paths introduced by the LRC / execlists support. As the execlists request is now part of the gem request it is possible and desirable to unify the request life-cycles for execlist and legacy requests. Added a c