Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-23 Thread Takashi Iwai
On Thu, 23 Jul 2015 08:25:21 +0200, David Henningsson wrote: > > > > On 2015-07-23 08:17, David Henningsson wrote: > > I'm about to go on vacation so it would be good to get some closure > > here. If you both prefer this setup, how about I remove "struct > > i915_audio_hotplug_info" for now? We

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
On 2015-07-23 08:17, David Henningsson wrote: I'm about to go on vacation so it would be good to get some closure here. If you both prefer this setup, how about I remove "struct i915_audio_hotplug_info" for now? We will then have: const struct i915_audio_component_audio_ops { voi

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
On 2015-07-22 22:31, Takashi Iwai wrote: On Wed, 22 Jul 2015 19:52:23 +0200, David Henningsson wrote: On 2015-07-22 16:13, Vinod Koul wrote: On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote: On Wed, 22 Jul 2015 10:50:03 +0200, David Henningsson wrote: struct i915_audio_

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Vinod Koul
On Wed, Jul 22, 2015 at 10:31:45PM +0200, Takashi Iwai wrote: > > > That depends on the device we register this with. Actually this makes more > > > sense to me :) > > > > > > If we register with struct device *audio_dev, which in this case would be > > > the codec device we create while probing th

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Takashi Iwai
On Wed, 22 Jul 2015 19:52:23 +0200, David Henningsson wrote: > > > > On 2015-07-22 16:13, Vinod Koul wrote: > > On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote: > >> On Wed, 22 Jul 2015 10:50:03 +0200, > >> David Henningsson wrote: > >>> > >struct i915_audio_component { > >>

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
On 2015-07-22 16:13, Vinod Koul wrote: On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote: On Wed, 22 Jul 2015 10:50:03 +0200, David Henningsson wrote: struct i915_audio_component { struct device *dev; + struct hdac_bus *hdac_bus; If we want to be more generic,

[Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
This struct will be used to transfer information from the i915 driver to the hda driver on HDMI hotplug events. Signed-off-by: David Henningsson --- include/drm/i915_component.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/drm/i915_component.h b/include/drm/i

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Vinod Koul
On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote: > On Wed, 22 Jul 2015 10:50:03 +0200, > David Henningsson wrote: > > > > >> struct i915_audio_component { > > >> struct device *dev; > > >> +struct hdac_bus *hdac_bus; > > > > > > If we want to be more generic, using

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Takashi Iwai
On Wed, 22 Jul 2015 10:50:03 +0200, David Henningsson wrote: > > >> struct i915_audio_component { > >>struct device *dev; > >> + struct hdac_bus *hdac_bus; > > > > If we want to be more generic, using a struct device would be better, > > e.g. > > struct device *audio_dev; > > Does this

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
On 2015-07-22 10:22, Takashi Iwai wrote: On Tue, 21 Jul 2015 09:57:24 +0200, David Henningsson wrote: This struct will be used to transfer information from the i915 driver to the hda driver on HDMI hotplug events. Signed-off-by: David Henningsson Looks good to me, just a few nitpicking:

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Takashi Iwai
On Tue, 21 Jul 2015 09:57:24 +0200, David Henningsson wrote: > > This struct will be used to transfer information from the i915 > driver to the hda driver on HDMI hotplug events. > > Signed-off-by: David Henningsson Looks good to me, just a few nitpicking: > --- > include/drm/i915_component.h

[Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-21 Thread David Henningsson
This struct will be used to transfer information from the i915 driver to the hda driver on HDMI hotplug events. Signed-off-by: David Henningsson --- include/drm/i915_component.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/drm/i915_component.h b/include/drm/