Re: [Intel-gfx] [PATCH 1/4] drm/i915/bxt: Avoid early timeout during PLL enable

2016-06-28 Thread Tvrtko Ursulin
On 28/06/16 11:37, Imre Deak wrote: Since wait_for_atomic doesn't re-check the wait-for condition after expiry of the timeout it can fail when called from non-atomic context even if the condition is set correctly before the expiry. Fix this by using the non-atomic wait_for instead. I noticed th

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bxt: Avoid early timeout during PLL enable

2016-06-28 Thread Tvrtko Ursulin
On 28/06/16 12:16, Imre Deak wrote: On ti, 2016-06-28 at 12:05 +0100, Tvrtko Ursulin wrote: On 28/06/16 11:48, Chris Wilson wrote: On Tue, Jun 28, 2016 at 01:37:30PM +0300, Imre Deak wrote: Since wait_for_atomic doesn't re-check the wait-for condition after expiry of the timeout it can fail w

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bxt: Avoid early timeout during PLL enable

2016-06-28 Thread Imre Deak
On ti, 2016-06-28 at 12:05 +0100, Tvrtko Ursulin wrote: > On 28/06/16 11:48, Chris Wilson wrote: > > On Tue, Jun 28, 2016 at 01:37:30PM +0300, Imre Deak wrote: > > > Since wait_for_atomic doesn't re-check the wait-for condition after > > > expiry of the timeout it can fail when called from non-atom

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bxt: Avoid early timeout during PLL enable

2016-06-28 Thread Chris Wilson
On Tue, Jun 28, 2016 at 12:05:42PM +0100, Tvrtko Ursulin wrote: > > On 28/06/16 11:48, Chris Wilson wrote: > >On Tue, Jun 28, 2016 at 01:37:30PM +0300, Imre Deak wrote: > >>Since wait_for_atomic doesn't re-check the wait-for condition after > >>expiry of the timeout it can fail when called from no

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bxt: Avoid early timeout during PLL enable

2016-06-28 Thread Tvrtko Ursulin
On 28/06/16 11:48, Chris Wilson wrote: On Tue, Jun 28, 2016 at 01:37:30PM +0300, Imre Deak wrote: Since wait_for_atomic doesn't re-check the wait-for condition after expiry of the timeout it can fail when called from non-atomic context even if the condition is set correctly before the expiry. F

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bxt: Avoid early timeout during PLL enable

2016-06-28 Thread Imre Deak
On ti, 2016-06-28 at 11:48 +0100, Chris Wilson wrote: > On Tue, Jun 28, 2016 at 01:37:30PM +0300, Imre Deak wrote: > > Since wait_for_atomic doesn't re-check the wait-for condition after > > expiry of the timeout it can fail when called from non-atomic > > context > > even if the condition is set c

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bxt: Avoid early timeout during PLL enable

2016-06-28 Thread Chris Wilson
On Tue, Jun 28, 2016 at 01:37:30PM +0300, Imre Deak wrote: > Since wait_for_atomic doesn't re-check the wait-for condition after > expiry of the timeout it can fail when called from non-atomic context > even if the condition is set correctly before the expiry. Fix this by > using the non-atomic wai

[Intel-gfx] [PATCH 1/4] drm/i915/bxt: Avoid early timeout during PLL enable

2016-06-28 Thread Imre Deak
Since wait_for_atomic doesn't re-check the wait-for condition after expiry of the timeout it can fail when called from non-atomic context even if the condition is set correctly before the expiry. Fix this by using the non-atomic wait_for instead. I noticed this via the PLL locking timing out incor