Re: [Intel-gfx] [PATCH 1/3] drm/i915: Hold an object reference whilst we shrink it

2013-09-05 Thread Daniel Vetter
On Thu, Sep 05, 2013 at 11:28:05AM +0100, Chris Wilson wrote: > On Thu, Sep 05, 2013 at 12:16:13PM +0200, Daniel Vetter wrote: > > On Wed, Sep 04, 2013 at 10:45:50AM +0100, Chris Wilson wrote: > > > Whilst running the shrinker, we need to hold a reference as we unbind > > > the objects, or else we

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Hold an object reference whilst we shrink it

2013-09-05 Thread Chris Wilson
On Thu, Sep 05, 2013 at 12:16:13PM +0200, Daniel Vetter wrote: > On Wed, Sep 04, 2013 at 10:45:50AM +0100, Chris Wilson wrote: > > Whilst running the shrinker, we need to hold a reference as we unbind > > the objects, or else we may end up waiting for and retiring requests, > > which in turn may re

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Hold an object reference whilst we shrink it

2013-09-05 Thread Daniel Vetter
On Wed, Sep 04, 2013 at 10:45:50AM +0100, Chris Wilson wrote: > Whilst running the shrinker, we need to hold a reference as we unbind > the objects, or else we may end up waiting for and retiring requests, > which in turn may result in this object being freed. > > This is very similar to the evict

[Intel-gfx] [PATCH 1/3] drm/i915: Hold an object reference whilst we shrink it

2013-09-04 Thread Chris Wilson
Whilst running the shrinker, we need to hold a reference as we unbind the objects, or else we may end up waiting for and retiring requests, which in turn may result in this object being freed. This is very similar to the eviction code which also has to be very careful to keep a reference to its ob