Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check for error before calling cmpxchg()

2019-12-06 Thread Matthew Auld
On Fri, 6 Dec 2019 at 16:04, Chris Wilson wrote: > > Only do the locked compare of the existing fence->error if we actually > need to set an error. As we tend to call i915_sw_fence_set_error_once() > unconditionally, it saves on typing to put the common has-error check > into the inline. > > Signe

[Intel-gfx] [PATCH 1/3] drm/i915: Check for error before calling cmpxchg()

2019-12-06 Thread Chris Wilson
Only do the locked compare of the existing fence->error if we actually need to set an error. As we tend to call i915_sw_fence_set_error_once() unconditionally, it saves on typing to put the common has-error check into the inline. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_sw_fence