Re: [Intel-gfx] [PATCH 1/3] drm/i915: BUG_ON() when cmd/reg tables are not sorted

2014-04-02 Thread Daniel Vetter
On Wed, Apr 02, 2014 at 12:11:37PM +0300, Jani Nikula wrote: > On Thu, 27 Mar 2014, bradley.d.vol...@intel.com wrote: > > From: Brad Volkin > > > > As suggested during review, this makes it much more obvious > > when the tables are not sorted. > > Let's look at the optimizations later. > > Revie

Re: [Intel-gfx] [PATCH 1/3] drm/i915: BUG_ON() when cmd/reg tables are not sorted

2014-04-02 Thread Jani Nikula
On Thu, 27 Mar 2014, bradley.d.vol...@intel.com wrote: > From: Brad Volkin > > As suggested during review, this makes it much more obvious > when the tables are not sorted. Let's look at the optimizations later. Reviewed-by: Jani Nikula > > Cc: Jani Nikula > Signed-off-by: Brad Volkin > ---

Re: [Intel-gfx] [PATCH 1/3] drm/i915: BUG_ON() when cmd/reg tables are not sorted

2014-03-27 Thread Volkin, Bradley D
On Thu, Mar 27, 2014 at 02:47:03PM -0700, Kenneth Graunke wrote: > Does any code actually rely on the tables being sorted? Not today. The idea was to make it easier to move to an algorithm that does in the future. For example, I thought binary search might be an easy win. > > I didn't see any ea

Re: [Intel-gfx] [PATCH 1/3] drm/i915: BUG_ON() when cmd/reg tables are not sorted

2014-03-27 Thread Kenneth Graunke
On 03/27/2014 11:43 AM, bradley.d.vol...@intel.com wrote: > From: Brad Volkin > > As suggested during review, this makes it much more obvious > when the tables are not sorted. > > Cc: Jani Nikula > Signed-off-by: Brad Volkin > --- > drivers/gpu/drm/i915/i915_cmd_parser.c | 31

[Intel-gfx] [PATCH 1/3] drm/i915: BUG_ON() when cmd/reg tables are not sorted

2014-03-27 Thread bradley . d . volkin
From: Brad Volkin As suggested during review, this makes it much more obvious when the tables are not sorted. Cc: Jani Nikula Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_cmd_parser.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --g