Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add bind/unbind object functions to VM

2013-07-15 Thread Daniel Vetter
On Mon, Jul 15, 2013 at 08:35:43PM -0700, Ben Widawsky wrote: > On Sat, Jul 13, 2013 at 11:33:22AM +0200, Daniel Vetter wrote: > > On Fri, Jul 12, 2013 at 09:45:54PM -0700, Ben Widawsky wrote: > > > As we plumb the code with more VM information, it has become more > > > obvious that the easiest way

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add bind/unbind object functions to VM

2013-07-15 Thread Daniel Vetter
On Mon, Jul 15, 2013 at 09:00:54PM -0700, Ben Widawsky wrote: > On Mon, Jul 15, 2013 at 08:35:43PM -0700, Ben Widawsky wrote: > > To me, aliasing ppgtt is just a wart that doesn't fit well with > > anything. As such, my plan was to hide as much of it as possible in ggtt > > functions. Using some ki

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add bind/unbind object functions to VM

2013-07-15 Thread Ben Widawsky
On Mon, Jul 15, 2013 at 08:35:43PM -0700, Ben Widawsky wrote: > On Sat, Jul 13, 2013 at 11:33:22AM +0200, Daniel Vetter wrote: > > On Fri, Jul 12, 2013 at 09:45:54PM -0700, Ben Widawsky wrote: > > > As we plumb the code with more VM information, it has become more > > > obvious that the easiest way

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add bind/unbind object functions to VM

2013-07-15 Thread Ben Widawsky
On Sat, Jul 13, 2013 at 11:33:22AM +0200, Daniel Vetter wrote: > On Fri, Jul 12, 2013 at 09:45:54PM -0700, Ben Widawsky wrote: > > As we plumb the code with more VM information, it has become more > > obvious that the easiest way to deal with bind and unbind is to simply > > put the function pointe

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add bind/unbind object functions to VM

2013-07-13 Thread Daniel Vetter
On Fri, Jul 12, 2013 at 09:45:54PM -0700, Ben Widawsky wrote: > As we plumb the code with more VM information, it has become more > obvious that the easiest way to deal with bind and unbind is to simply > put the function pointers in the vm, and let those choose the correct > way to handle the page

[Intel-gfx] [PATCH 1/3] drm/i915: Add bind/unbind object functions to VM

2013-07-12 Thread Ben Widawsky
As we plumb the code with more VM information, it has become more obvious that the easiest way to deal with bind and unbind is to simply put the function pointers in the vm, and let those choose the correct way to handle the page table updates. This change allows many places in the code to simply b