Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Allow universal planes to position

2015-03-10 Thread Daniel Vetter
On Tue, Mar 10, 2015 at 09:23:54AM +0530, sonika wrote: > > On Monday 09 March 2015 02:16 PM, Daniel Vetter wrote: > >On Mon, Mar 09, 2015 at 08:33:27AM +0530, sonika wrote: > >>On Thursday 05 March 2015 06:24 PM, Daniel Vetter wrote: > >>>On Thu, Mar 05, 2015 at 02:51:26PM +0530, Sonika Jindal wr

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Allow universal planes to position

2015-03-09 Thread sonika
On Monday 09 March 2015 02:16 PM, Daniel Vetter wrote: On Mon, Mar 09, 2015 at 08:33:27AM +0530, sonika wrote: On Thursday 05 March 2015 06:24 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 02:51:26PM +0530, Sonika Jindal wrote: Signed-off-by: Sonika Jindal Imo this needs a little more co

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Allow universal planes to position

2015-03-09 Thread Daniel Vetter
On Mon, Mar 09, 2015 at 05:20:39PM +0200, Ville Syrjälä wrote: > On Mon, Mar 09, 2015 at 09:46:27AM +0100, Daniel Vetter wrote: > > On Mon, Mar 09, 2015 at 08:33:27AM +0530, sonika wrote: > > > > > > On Thursday 05 March 2015 06:24 PM, Daniel Vetter wrote: > > > >On Thu, Mar 05, 2015 at 02:51:26PM

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Allow universal planes to position

2015-03-09 Thread Ville Syrjälä
On Mon, Mar 09, 2015 at 09:46:27AM +0100, Daniel Vetter wrote: > On Mon, Mar 09, 2015 at 08:33:27AM +0530, sonika wrote: > > > > On Thursday 05 March 2015 06:24 PM, Daniel Vetter wrote: > > >On Thu, Mar 05, 2015 at 02:51:26PM +0530, Sonika Jindal wrote: > > >>Signed-off-by: Sonika Jindal > > >Imo

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Allow universal planes to position

2015-03-09 Thread Daniel Vetter
On Mon, Mar 09, 2015 at 08:33:27AM +0530, sonika wrote: > > On Thursday 05 March 2015 06:24 PM, Daniel Vetter wrote: > >On Thu, Mar 05, 2015 at 02:51:26PM +0530, Sonika Jindal wrote: > >>Signed-off-by: Sonika Jindal > >Imo this needs a little more commit message, and more important it needs > >ig

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Allow universal planes to position

2015-03-08 Thread sonika
On Thursday 05 March 2015 06:24 PM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 02:51:26PM +0530, Sonika Jindal wrote: Signed-off-by: Sonika Jindal Imo this needs a little more commit message, and more important it needs igt test coverage. Best approach there is probably to take the plane te

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Allow universal planes to position

2015-03-05 Thread Daniel Vetter
On Thu, Mar 05, 2015 at 02:51:26PM +0530, Sonika Jindal wrote: > Signed-off-by: Sonika Jindal Imo this needs a little more commit message, and more important it needs igt test coverage. Best approach there is probably to take the plane test we have already and extend it to the primary plane. -Dan

[Intel-gfx] [PATCH 1/3] drm/i915/skl: Allow universal planes to position

2015-03-05 Thread Sonika Jindal
Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_display.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 437a679..e1b0c4d 100644 --- a/drivers/gpu/drm/i915/intel_display.c