Re: [Intel-gfx] [PATCH 1/3] drm/i915/psr: Share the computation of idle frames

2019-12-30 Thread Anshuamn Gupta
On 2019-11-14 at 04:47:35 +0530, Souza, Jose wrote: > On Wed, 2019-11-13 at 18:04 +0530, Anshuamn Gupta wrote: > > Looks good to me, there is a minor comment see below. > > On 2019-10-31 at 17:14:20 -0700, José Roberto de Souza wrote: > > > Both activate functions and the dc3co disable function wer

Re: [Intel-gfx] [PATCH 1/3] drm/i915/psr: Share the computation of idle frames

2019-11-13 Thread Souza, Jose
On Wed, 2019-11-13 at 18:04 +0530, Anshuamn Gupta wrote: > Looks good to me, there is a minor comment see below. > On 2019-10-31 at 17:14:20 -0700, José Roberto de Souza wrote: > > Both activate functions and the dc3co disable function were doing > > the > > same thing, so better move to a function

Re: [Intel-gfx] [PATCH 1/3] drm/i915/psr: Share the computation of idle frames

2019-11-13 Thread Anshuamn Gupta
Looks good to me, there is a minor comment see below. On 2019-10-31 at 17:14:20 -0700, José Roberto de Souza wrote: > Both activate functions and the dc3co disable function were doing the > same thing, so better move to a function and share. > Also while at it adding a WARN_ON to catch invalid valu

[Intel-gfx] [PATCH 1/3] drm/i915/psr: Share the computation of idle frames

2019-10-31 Thread José Roberto de Souza
Both activate functions and the dc3co disable function were doing the same thing, so better move to a function and share. Also while at it adding a WARN_ON to catch invalid values. Cc: Anshuman Gupta Cc: Imre Deak Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.