Re: [Intel-gfx] [PATCH 1/3] drm/i915/dsi: clean up MIPI DSI pipe vs. port usage

2014-11-26 Thread Singh, Gaurav K
On 11/14/2014 8:24 PM, Jani Nikula wrote: MIPI DSI works on ports A and C, which map to pipes A and B, respectively. Things are going to get more complicated with the introduction of dual link DSI support, so clean up the register defines and code to match reality. Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dsi: clean up MIPI DSI pipe vs. port usage

2014-11-26 Thread Singh, Gaurav K
On 11/26/2014 11:38 PM, Daniel Vetter wrote: On Wed, Nov 26, 2014 at 10:50:46PM +0530, Singh, Gaurav K wrote: This patch has some style issues. Please address them. Please be more specific, that's rather non-actionable review. Also general rule of thumb is that if it doesn't look offensive a

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dsi: clean up MIPI DSI pipe vs. port usage

2014-11-26 Thread Daniel Vetter
On Wed, Nov 26, 2014 at 10:50:46PM +0530, Singh, Gaurav K wrote: > This patch has some style issues. Please address them. Please be more specific, that's rather non-actionable review. Also general rule of thumb is that if it doesn't look offensive and the patch is otherwise good it still deserve

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dsi: clean up MIPI DSI pipe vs. port usage

2014-11-26 Thread Singh, Gaurav K
On 11/14/2014 8:24 PM, Jani Nikula wrote: MIPI DSI works on ports A and C, which map to pipes A and B, respectively. Things are going to get more complicated with the introduction of dual link DSI support, so clean up the register defines and code to match reality. Signed-off-by: Jani Nikula -

[Intel-gfx] [PATCH 1/3] drm/i915/dsi: clean up MIPI DSI pipe vs. port usage

2014-11-14 Thread Jani Nikula
MIPI DSI works on ports A and C, which map to pipes A and B, respectively. Things are going to get more complicated with the introduction of dual link DSI support, so clean up the register defines and code to match reality. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 30