Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA

2014-10-06 Thread Joe Konno
Reviewed-By: Joe Konno On 09/29/2014 03:49 PM, U. Artie Eoff wrote: > Improper truncated integer division in the scale() function causes > actual_brightness != brightness. This (partial) work-around should be > sufficient for a majority of use-cases, but it is by no means a complete > solution. >

Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA

2014-09-30 Thread Eoff, Ullysses A
September 30, 2014 9:32 AM > > > To: Eoff, Ullysses A > > > Cc: dan...@ffwll.ch; intel-gfx@lists.freedesktop.org > > > Subject: Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() > > > math WA > > > > > > On Tue, Sep 30, 2014 at 0

Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA

2014-09-30 Thread Daniel Vetter
> Cc: dan...@ffwll.ch; intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() > > math WA > > > > On Tue, Sep 30, 2014 at 02:58:54PM +, Eoff, Ullysses A wrote: > > > On Tue, 2014-09-30 at 10:04 +0200, Dan

Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA

2014-09-30 Thread Eoff, Ullysses A
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, September 30, 2014 9:32 AM > To: Eoff, Ullysses A > Cc: dan...@ffwll.ch; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATC

Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA

2014-09-30 Thread Daniel Vetter
On Tue, Sep 30, 2014 at 02:58:54PM +, Eoff, Ullysses A wrote: > On Tue, 2014-09-30 at 10:04 +0200, Daniel Vetter wrote: > > On Mon, Sep 29, 2014 at 03:49:32PM -0700, U. Artie Eoff wrote: > > > Improper truncated integer division in the scale() function causes > > > actual_brightness != brightne

Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA

2014-09-30 Thread Eoff, Ullysses A
On Tue, 2014-09-30 at 10:04 +0200, Daniel Vetter wrote: > On Mon, Sep 29, 2014 at 03:49:32PM -0700, U. Artie Eoff wrote: > > Improper truncated integer division in the scale() function causes > > actual_brightness != brightness. This (partial) work-around should be > > sufficient for a majority of

Re: [Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA

2014-09-30 Thread Daniel Vetter
On Mon, Sep 29, 2014 at 03:49:32PM -0700, U. Artie Eoff wrote: > Improper truncated integer division in the scale() function causes > actual_brightness != brightness. This (partial) work-around should be > sufficient for a majority of use-cases, but it is by no means a complete > solution. > > TOD

[Intel-gfx] [PATCH 1/2 v3] drm/i915: intel_backlight scale() math WA

2014-09-29 Thread U. Artie Eoff
Improper truncated integer division in the scale() function causes actual_brightness != brightness. This (partial) work-around should be sufficient for a majority of use-cases, but it is by no means a complete solution. TODO: Determine how best to scale "user" values to "hw" values, and vice-versa