On Sat, Oct 12, 2013 at 1:19 AM, Jesse Barnes wrote:
> But I don't want this fix (once I fix the locking) blocked on
> those tests, since they'll probably take me a few days and people are
> already using the original version, which is missing the locks for the
> backlight class and ASLE call site
On Sat, Oct 12, 2013 at 1:55 AM, Daniel Vetter wrote:
> On Sat, Oct 12, 2013 at 1:19 AM, Jesse Barnes
> wrote:
>> On Fri, 11 Oct 2013 14:34:35 -0700
>> Jesse Barnes wrote:
>>
>>> > Ideas:
>>> > - Make sure all lvds/edp connectors are enabled and bash on all backlight
>>> > interfaces (with ig
On Sat, Oct 12, 2013 at 1:19 AM, Jesse Barnes wrote:
> On Fri, 11 Oct 2013 14:34:35 -0700
> Jesse Barnes wrote:
>
>> > Ideas:
>> > - Make sure all lvds/edp connectors are enabled and bash on all backlight
>> > interfaces (with igt_fork it's easy to do that concurrently).
>> > - Race the above w
On Fri, 11 Oct 2013 14:34:35 -0700
Jesse Barnes wrote:
> > Ideas:
> > - Make sure all lvds/edp connectors are enabled and bash on all backlight
> > interfaces (with igt_fork it's easy to do that concurrently).
> > - Race the above with output changes: dpms on/off and changing the crtc
> > aro
On Fri, 11 Oct 2013 23:31:10 +0200
Daniel Vetter wrote:
> On Fri, Oct 11, 2013 at 11:31:53AM -0700, Jesse Barnes wrote:
>
> [snip]
>
> > static int intel_panel_get_brightness(struct backlight_device *bd)
> > {
> > - struct drm_device *dev = bl_get_data(bd);
> > - return intel_panel_get_ba
On Fri, Oct 11, 2013 at 11:31:53AM -0700, Jesse Barnes wrote:
[snip]
> static int intel_panel_get_brightness(struct backlight_device *bd)
> {
> - struct drm_device *dev = bl_get_data(bd);
> - return intel_panel_get_backlight(dev);
> + struct intel_connector *connector = bl_get_data(
On VLV/BYT, backlight controls a per-pipe, so when adjusting the
backlight we need to pass the correct info. So make the externally
visible backlight functions take a connector argument, which can be used
internally to figure out the pipe backlight to adjust.
v2: make connector pipe lookup check
