Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

2016-12-13 Thread Matthew Auld
On 13 December 2016 at 16:25, Joonas Lahtinen wrote: > On ti, 2016-12-13 at 16:00 +, Matthew Auld wrote: >> In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, with the >> simple goal of expressing warnings which are truly insane, and so are >> only really useful for CI where we ha

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

2016-12-13 Thread Joonas Lahtinen
On ti, 2016-12-13 at 16:00 +, Matthew Auld wrote: > In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, with the > simple goal of expressing warnings which are truly insane, and so are > only really useful for CI where we have some abusive tests. > > v2: >   - use BUILD_BUG_ON_INVA

[Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

2016-12-13 Thread Matthew Auld
In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, with the simple goal of expressing warnings which are truly insane, and so are only really useful for CI where we have some abusive tests. v2: - use BUILD_BUG_ON_INVALID for !DEBUG_GEM - clarify commit message Cc: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

2016-12-02 Thread Chris Wilson
On Fri, Dec 02, 2016 at 03:11:05PM +, Matthew Auld wrote: > On 2 December 2016 at 13:54, Chris Wilson wrote: > > On Fri, Dec 02, 2016 at 01:23:13PM +, Matthew Auld wrote: > >> In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this > >> will enable us to freely add warnings wh

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

2016-12-02 Thread Matthew Auld
On 2 December 2016 at 13:54, Chris Wilson wrote: > On Fri, Dec 02, 2016 at 01:23:13PM +, Matthew Auld wrote: >> In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this >> will enable us to freely add warnings which our CI will hopefully catch >> but without fear of impacting produ

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

2016-12-02 Thread Chris Wilson
On Fri, Dec 02, 2016 at 01:23:13PM +, Matthew Auld wrote: > In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this > will enable us to freely add warnings which our CI will hopefully catch > but without fear of impacting production machines. > > Suggested-by: Chris Wilson > Sign

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

2016-12-02 Thread Ville Syrjälä
On Fri, Dec 02, 2016 at 01:23:13PM +, Matthew Auld wrote: > In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this > will enable us to freely add warnings which our CI will hopefully catch > but without fear of impacting production machines. Impacting performance? > > Suggested

[Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

2016-12-02 Thread Matthew Auld
In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this will enable us to freely add warnings which our CI will hopefully catch but without fear of impacting production machines. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem.h | 2 ++ 1 fi