Re: [Intel-gfx] [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter

2012-03-28 Thread Ben Widawsky
On Fri, 23 Mar 2012 11:57:18 -0300 Eugeni Dodonov wrote: > This allows to select which rc6 modes are to be used via kernel > parameter, via a bitmask parameter. E.g.: > > - to enable rc6, i915_enable_rc6=1 > - to enable rc6 and deep rc6, i915_enable_rc6=3 > - to enable rc6 and deepest rc6, use i

[Intel-gfx] [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter

2012-03-23 Thread Eugeni Dodonov
This allows to select which rc6 modes are to be used via kernel parameter, via a bitmask parameter. E.g.: - to enable rc6, i915_enable_rc6=1 - to enable rc6 and deep rc6, i915_enable_rc6=3 - to enable rc6 and deepest rc6, use i915_enable_rc6=5 - to enable rc6, deep and deepest rc6, use i915_enable

Re: [Intel-gfx] [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter

2012-02-11 Thread Eugeni Dodonov
On Sat, Feb 11, 2012 at 16:13, Kai Krakow wrote: > Chris Wilson schrieb: > > >> + if (rc6_mode > 0) { > > I'm a little uneasy mixing signs and bitmasks, and this test looks a > > little pointless as intel_enable_rc6 now returns the bitmask. Kill it > > and we kill one level of indentation! >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter

2012-02-11 Thread Kai Krakow
Chris Wilson schrieb: >> + if (rc6_mode > 0) { > I'm a little uneasy mixing signs and bitmasks, and this test looks a > little pointless as intel_enable_rc6 now returns the bitmask. Kill it > and we kill one level of indentation! I think not, because Eugeni documented "-1" as the chipset def

Re: [Intel-gfx] [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter

2012-02-11 Thread Chris Wilson
On Sat, 11 Feb 2012 10:34:14 -0200, Eugeni Dodonov wrote: > This allows to select which rc6 modes are to be used via kernel parameter, > via a bitmask parameter. E.g.: > > - to enable rc6, i915_enable_rc6=1 > - to enable rc6 and deep rc6, i915_enable_rc6=3 > - to enable rc6 and deepest rc6, use

[Intel-gfx] [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter

2012-02-11 Thread Eugeni Dodonov
This allows to select which rc6 modes are to be used via kernel parameter, via a bitmask parameter. E.g.: - to enable rc6, i915_enable_rc6=1 - to enable rc6 and deep rc6, i915_enable_rc6=3 - to enable rc6 and deepest rc6, use i915_enable_rc6=5 - to enable rc6, deep and deepest rc6, use i915_enable