Re: [Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-14 Thread Chris Wilson
On Wed, 13 Jul 2011 14:38:17 -0700, Ben Widawsky wrote: > > Signed-off-by: Ben Widawsky Reviewed-by: Chris Wilson -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedeskto

[Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-13 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_drv.c | 24 drivers/gpu/drm/i915/i915_drv.h | 20 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index d

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-13 Thread Keith Packard
On Wed, 6 Jul 2011 15:14:52 -0700, Ben Widawsky wrote: > > Signed-off-by: Ben Widawsky This patch series doesn't apply to -next anymore; care to clean it up so I can merge it in? (too many -fixes applied for 3.0, I fear) -- keith.pack...@intel.com pgp7clRhEsCGt.pgp Description: PGP signat

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-07 Thread Jesse Barnes
On Wed, 06 Jul 2011 17:37:16 -0700 Keith Packard wrote: > On Wed, 6 Jul 2011 16:16:01 -0700, Ben Widawsky wrote: > Non-text part: multipart/signed > > > I've seen no regressions on Nexuiz. > > 'this doesn't seem to hurt any' is hardly a strong recommendation... If anything, using __read_mostl

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-06 Thread Chris Wilson
On Wed, 6 Jul 2011 15:14:52 -0700, Ben Widawsky wrote: And programmer hints too. They serve as useful documentation on the expected usage of the variable as well. But maybe that's just me... -Chris -- Chris Wilson, Intel Open Source Technology Centre ___

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-06 Thread Ted Phelps
Ben Widawsky writes: > On Wed, Jul 06, 2011 at 04:03:14PM -0700, Keith Packard wrote: > > On Wed, 6 Jul 2011 15:14:52 -0700, Ben Widawsky wrote: > > > > > -static int i915_modeset =3D -1; > > > +static int i915_modeset __read_mostly =3D -1; > > > > What effect does this have? Performance? Code si

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-06 Thread Keith Packard
On Wed, 6 Jul 2011 16:16:01 -0700, Ben Widawsky wrote: Non-text part: multipart/signed > I've seen no regressions on Nexuiz. 'this doesn't seem to hurt any' is hardly a strong recommendation... -- keith.pack...@intel.com pgp3gwbqzSTIA.pgp Description: PGP signature __

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-06 Thread Ben Widawsky
On Wed, Jul 06, 2011 at 04:03:14PM -0700, Keith Packard wrote: > On Wed, 6 Jul 2011 15:14:52 -0700, Ben Widawsky wrote: > > > > -static int i915_modeset = -1; > > +static int i915_modeset __read_mostly = -1; > > What effect does this have? Performance? Code size? More warnings? __read_mostly

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-06 Thread Keith Packard
On Wed, 6 Jul 2011 15:14:52 -0700, Ben Widawsky wrote: > -static int i915_modeset = -1; > +static int i915_modeset __read_mostly = -1; What effect does this have? Performance? Code size? More warnings? -- keith.pack...@intel.com pgpVFVofyIu2e.pgp Description: PGP signature

[Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-06 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_drv.c | 24 drivers/gpu/drm/i915/i915_drv.h | 20 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 6