Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in single function

2018-05-30 Thread Jani Nikula
On Thu, 31 May 2018, "Xu, Colin" wrote: > Hi Jani, any comments? Without correct PCH type, BXT in virtualization > will fail to boot due to display initialization fail. If any more > input required, please kindly let me know. See [1] and please provide your Tested-by and/or Reviewed-by on the rel

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in single function

2018-05-30 Thread Xu, Colin
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Colin Xu >Sent: Wednesday, May 30, 2018 14:26 >To: Nikula, Jani ; intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in single function

2018-05-28 Thread Colin Xu
On 05/29/2018 01:45 PM, Jani Nikula wrote: On Wed, 30 May 2018, Colin Xu wrote: On 05/28/2018 09:42 PM, Jani Nikula wrote: On Mon, 28 May 2018, Jani Nikula wrote: On Mon, 28 May 2018, Jani Nikula wrote: On Tue, 29 May 2018, colin...@intel.com wrote: From: Colin Xu The existing way to u

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in single function

2018-05-28 Thread Jani Nikula
On Wed, 30 May 2018, Colin Xu wrote: > On 05/28/2018 09:42 PM, Jani Nikula wrote: >> On Mon, 28 May 2018, Jani Nikula wrote: >>> On Mon, 28 May 2018, Jani Nikula wrote: On Tue, 29 May 2018, colin...@intel.com wrote: > From: Colin Xu > > The existing way to update virtual PCH wi

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in single function

2018-05-28 Thread Colin Xu
On 05/28/2018 09:42 PM, Jani Nikula wrote: On Mon, 28 May 2018, Jani Nikula wrote: On Mon, 28 May 2018, Jani Nikula wrote: On Tue, 29 May 2018, colin...@intel.com wrote: From: Colin Xu The existing way to update virtual PCH will return wrong PCH type in case the host doesn't have PCH: -

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in single function

2018-05-28 Thread Jani Nikula
On Mon, 28 May 2018, Jani Nikula wrote: > On Mon, 28 May 2018, Jani Nikula wrote: >> On Tue, 29 May 2018, colin...@intel.com wrote: >>> From: Colin Xu >>> >>> The existing way to update virtual PCH will return wrong PCH type >>> in case the host doesn't have PCH: >>> - intel_virt_detect_pch re

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in single function

2018-05-28 Thread Jani Nikula
On Mon, 28 May 2018, Jani Nikula wrote: > On Tue, 29 May 2018, colin...@intel.com wrote: >> From: Colin Xu >> >> The existing way to update virtual PCH will return wrong PCH type >> in case the host doesn't have PCH: >> - intel_virt_detect_pch returns guessed PCH id 0 >> - id 0 maps to PCH_NO

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in single function

2018-05-28 Thread Jani Nikula
On Tue, 29 May 2018, colin...@intel.com wrote: > From: Colin Xu > > The existing way to update virtual PCH will return wrong PCH type > in case the host doesn't have PCH: > - intel_virt_detect_pch returns guessed PCH id 0 > - id 0 maps to PCH_NOP. >> should be PCH_NONE. > Since PCH_NONE and PC

[Intel-gfx] [PATCH 1/2] drm/i915: Update virtual PCH in single function

2018-05-27 Thread colin . xu
From: Colin Xu The existing way to update virtual PCH will return wrong PCH type in case the host doesn't have PCH: - intel_virt_detect_pch returns guessed PCH id 0 - id 0 maps to PCH_NOP. >> should be PCH_NONE. Since PCH_NONE and PCH_NOP are different types, mixing them up will break vbt ini