Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-04-11 Thread Ville Syrjälä
On Thu, Apr 11, 2019 at 12:11:42PM -0700, Manasi Navare wrote: > On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently we enable FEC even when DSC is no used. While that is > > theoretically valid supposedly there isn't much of a benefit from > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-04-11 Thread Manasi Navare
On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we enable FEC even when DSC is no used. While that is > theoretically valid supposedly there isn't much of a benefit from > this. But more importantly we do not account for the FEC link > bandwidth

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-03-27 Thread Ville Syrjälä
On Tue, Mar 26, 2019 at 11:10:44AM -0700, Manasi Navare wrote: > On Tue, Mar 26, 2019 at 06:16:57PM +0200, Ville Syrjälä wrote: > > On Tue, Mar 26, 2019 at 09:00:27AM -0700, Manasi Navare wrote: > > > On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-03-26 Thread Manasi Navare
On Tue, Mar 26, 2019 at 06:16:57PM +0200, Ville Syrjälä wrote: > On Tue, Mar 26, 2019 at 09:00:27AM -0700, Manasi Navare wrote: > > On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Currently we enable FEC even when DSC is no used. While that is

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-03-26 Thread Ville Syrjälä
On Tue, Mar 26, 2019 at 09:00:27AM -0700, Manasi Navare wrote: > On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently we enable FEC even when DSC is no used. While that is > > theoretically valid supposedly there isn't much of a benefit from > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-03-26 Thread Manasi Navare
On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we enable FEC even when DSC is no used. While that is > theoretically valid supposedly there isn't much of a benefit from > this. But more importantly we do not account for the FEC link > bandwidth

[Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä Currently we enable FEC even when DSC is no used. While that is theoretically valid supposedly there isn't much of a benefit from this. But more importantly we do not account for the FEC link bandwidth overhead (2.4%) in the non-DSC link bandwidth computations. So the code may