Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disallow pin ioctl completely for kms drivers

2015-02-23 Thread Daniel Vetter
On Mon, Feb 23, 2015 at 01:29:57PM -0800, Jesse Barnes wrote: > On 11/24/2014 06:13 AM, Chris Wilson wrote: > > On Mon, Nov 24, 2014 at 03:10:05PM +0100, Daniel Vetter wrote: > >> On Mon, Nov 24, 2014 at 10:35:29AM +, Chris Wilson wrote: > >>> Pinning is a useful tool and it would also be usefu

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disallow pin ioctl completely for kms drivers

2015-02-23 Thread Jesse Barnes
On 11/24/2014 06:13 AM, Chris Wilson wrote: > On Mon, Nov 24, 2014 at 03:10:05PM +0100, Daniel Vetter wrote: >> On Mon, Nov 24, 2014 at 10:35:29AM +, Chris Wilson wrote: >>> Pinning is a useful tool and it would also be useful to have again on >>> gen6+. >> >> I think softpin or similar is doab

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disallow pin ioctl completely for kms drivers

2014-11-24 Thread Chris Wilson
On Mon, Nov 24, 2014 at 03:10:05PM +0100, Daniel Vetter wrote: > On Mon, Nov 24, 2014 at 10:35:29AM +, Chris Wilson wrote: > > On Mon, Nov 24, 2014 at 11:30:24AM +0100, Daniel Vetter wrote: > > > The problem here is that SNA pins batchbuffers to etch out a bit more > > > performance. Iirc it st

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disallow pin ioctl completely for kms drivers

2014-11-24 Thread Daniel Vetter
On Mon, Nov 24, 2014 at 10:35:29AM +, Chris Wilson wrote: > On Mon, Nov 24, 2014 at 11:30:24AM +0100, Daniel Vetter wrote: > > The problem here is that SNA pins batchbuffers to etch out a bit more > > performance. Iirc it started out as a w/a for i830M (which we've > > implemented in the kernel

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disallow pin ioctl completely for kms drivers

2014-11-24 Thread Chris Wilson
On Mon, Nov 24, 2014 at 11:30:24AM +0100, Daniel Vetter wrote: > The problem here is that SNA pins batchbuffers to etch out a bit more > performance. Iirc it started out as a w/a for i830M (which we've > implemented in the kernel since a long time already). Hmm, we only finally fixed it in the ker

[Intel-gfx] [PATCH 1/2] drm/i915: Disallow pin ioctl completely for kms drivers

2014-11-24 Thread Daniel Vetter
The problem here is that SNA pins batchbuffers to etch out a bit more performance. Iirc it started out as a w/a for i830M (which we've implemented in the kernel since a long time already). The problem is that the pin ioctl wasn't added in commit d23db88c3ab233daed18709e3a24d6c95344117f Author: Chr