Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add BUG_ON when ring->private is NULL

2012-03-18 Thread Sean Paul
On Sun, Mar 18, 2012 at 2:09 PM, Daniel Vetter wrote: > On Fri, Mar 16, 2012 at 12:43:21PM -0400, Sean Paul wrote: >> I have experienced a number of NULL pointer dereferences on >> suspend/resume where ring->private is NULL. These come from failed >> initialization of the ring buffer. Sincce this

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add BUG_ON when ring->private is NULL

2012-03-18 Thread Daniel Vetter
On Fri, Mar 16, 2012 at 12:43:21PM -0400, Sean Paul wrote: > I have experienced a number of NULL pointer dereferences on > suspend/resume where ring->private is NULL. These come from failed > initialization of the ring buffer. Sincce this doesn't seem to be easily > recoverable, this patch adds a B

[Intel-gfx] [PATCH 1/2] drm/i915: Add BUG_ON when ring->private is NULL

2012-03-16 Thread Sean Paul
I have experienced a number of NULL pointer dereferences on suspend/resume where ring->private is NULL. These come from failed initialization of the ring buffer. Sincce this doesn't seem to be easily recoverable, this patch adds a BUG_ON and a bread crumb pointer for people who might encounter this