Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

2020-01-15 Thread Jani Nikula
On Wed, 15 Jan 2020, Jani Nikula wrote: > On Wed, 15 Jan 2020, Chris Wilson wrote: >> Quoting Jani Nikula (2019-12-05 15:43:40) >>> Add a debugfs subdirectory i915_params with all the i915 module >>> parameters. This is a first step, with lots of boilerplate, and not much >>> benefit yet. >> >> R

Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

2020-01-15 Thread Jani Nikula
On Wed, 15 Jan 2020, Chris Wilson wrote: > Quoting Jani Nikula (2019-12-05 15:43:40) >> Add a debugfs subdirectory i915_params with all the i915 module >> parameters. This is a first step, with lots of boilerplate, and not much >> benefit yet. > > Right, creates a mirror [more or less] of /sys/mod

Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

2020-01-15 Thread Chris Wilson
Quoting Jani Nikula (2019-12-05 15:43:40) > Add a debugfs subdirectory i915_params with all the i915 module > parameters. This is a first step, with lots of boilerplate, and not much > benefit yet. Right, creates a mirror [more or less] of /sys/module/i915/parameters. I probably would have used pa

Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

2020-01-08 Thread Jani Nikula
On Wed, 08 Jan 2020, Chris Wilson wrote: > Quoting Jani Nikula (2019-12-05 15:43:40) >> +static int i915_param_int_open(struct inode *inode, struct file *file) >> +{ >> + return single_open(file, i915_param_int_show, inode->i_private); > > What I've always wanted with this style of approach

Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

2020-01-08 Thread Chris Wilson
Quoting Jani Nikula (2019-12-05 15:43:40) > +static int i915_param_int_open(struct inode *inode, struct file *file) > +{ > + return single_open(file, i915_param_int_show, inode->i_private); What I've always wanted with this style of approach was a means that the parameter is only set while t

Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

2019-12-09 Thread Jani Nikula
On Thu, 05 Dec 2019, Tvrtko Ursulin wrote: > On 05/12/2019 15:43, Jani Nikula wrote: >> Add a debugfs subdirectory i915_params with all the i915 module >> parameters. This is a first step, with lots of boilerplate, and not much >> benefit yet. >> >> This will result in a new device specific debug

Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

2019-12-05 Thread Tvrtko Ursulin
On 05/12/2019 15:43, Jani Nikula wrote: Add a debugfs subdirectory i915_params with all the i915 module parameters. This is a first step, with lots of boilerplate, and not much benefit yet. This will result in a new device specific debugfs directory at /sys/kernel/debug/dri//i915_params duplica

[Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

2019-12-05 Thread Jani Nikula
Add a debugfs subdirectory i915_params with all the i915 module parameters. This is a first step, with lots of boilerplate, and not much benefit yet. This will result in a new device specific debugfs directory at /sys/kernel/debug/dri//i915_params duplicating the module specific sysfs directory at