Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-11 Thread Ben Widawsky
Way more coming in terms of sharing code. If you feel like looking into the future: http://cgit.freedesktop.org/~bwidawsk/drm-intel/log/?h=dynamic_pt_alloc I've hoped, and continue to hope to kill insert/clear_entires entirely. Still debugging some gen7 crap though for now. On Tue, Mar 11, 2014 a

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-11 Thread Chris Wilson
On Tue, Mar 11, 2014 at 09:39:30AM -0700, Ben Widawsky wrote: > On Tue, Mar 11, 2014 at 5:24 AM, Chris Wilson > wrote: > > On Sat, Mar 08, 2014 at 11:59:42AM -0800, Ben Widawsky wrote: > >> On Sat, Mar 08, 2014 at 11:58:16AM -0800, Ben Widawsky wrote: > >> > I'm not clear if the hardware is still

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-11 Thread Ben Widawsky
On Tue, Mar 11, 2014 at 5:24 AM, Chris Wilson wrote: > On Sat, Mar 08, 2014 at 11:59:42AM -0800, Ben Widawsky wrote: >> On Sat, Mar 08, 2014 at 11:58:16AM -0800, Ben Widawsky wrote: >> > I'm not clear if the hardware is still subject to the same prefetching >> > issues that made us use a scratch p

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-11 Thread Chris Wilson
On Sat, Mar 08, 2014 at 11:59:42AM -0800, Ben Widawsky wrote: > On Sat, Mar 08, 2014 at 11:58:16AM -0800, Ben Widawsky wrote: > > I'm not clear if the hardware is still subject to the same prefetching > > issues that made us use a scratch page in the first place. In either > > case, we're using gar

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-08 Thread Ben Widawsky
On Sat, Mar 08, 2014 at 11:58:16AM -0800, Ben Widawsky wrote: > I'm not clear if the hardware is still subject to the same prefetching > issues that made us use a scratch page in the first place. In either > case, we're using garbage with the current code (we will end up using > offset 0). > > Thi

[Intel-gfx] [PATCH 1/2] drm/i915/bdw: Use scratch page table for GEN8 PPGTT

2014-03-08 Thread Ben Widawsky
I'm not clear if the hardware is still subject to the same prefetching issues that made us use a scratch page in the first place. In either case, we're using garbage with the current code (we will end up using offset 0). This may be the cause of our current gem_cpu_reloc regression with PPGTT. I c