Re: [Intel-gfx] [PATCH 1/1] drm/i915: Drop unused register definitions

2022-01-10 Thread Lucas De Marchi
On Mon, Jan 10, 2022 at 12:55:36PM +0200, Jani Nikula wrote: On Fri, 07 Jan 2022, Lucas De Marchi wrote: On Fri, Jan 07, 2022 at 12:46:48PM +0200, Jani Nikula wrote: I still tell people to 1) split out register definitions to separate patches, and 2) add macros for the entire feature and full

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Drop unused register definitions

2022-01-10 Thread Jani Nikula
On Fri, 07 Jan 2022, Lucas De Marchi wrote: > On Fri, Jan 07, 2022 at 12:46:48PM +0200, Jani Nikula wrote: >>I still tell people to 1) split out register definitions to separate >>patches, and 2) add macros for the entire feature and full contents for >>each register, even if they remain unused. >

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Drop unused register definitions

2022-01-07 Thread Lucas De Marchi
On Fri, Jan 07, 2022 at 12:46:48PM +0200, Jani Nikula wrote: On Thu, 06 Jan 2022, Matt Roper wrote: A large percentage (nearly 25%) of the register and bit definitions in i915_reg.h are not used by the i915 driver and are effectively dead code. There are a few origins for these unused definiti

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Drop unused register definitions

2022-01-07 Thread Jani Nikula
On Thu, 06 Jan 2022, Matt Roper wrote: > A large percentage (nearly 25%) of the register and bit definitions in > i915_reg.h are not used by the i915 driver and are effectively dead > code. There are a few origins for these unused definitions: > > * Registers only accessed by workarounds that we