Re: [Intel-gfx] [PATCH 09/43] drm/i915: introduce a vtable for gpu core functions

2011-12-21 Thread Daniel Vetter
On Wed, Dec 14, 2011 at 03:06:34PM +, Chris Wilson wrote: > On Wed, 14 Dec 2011 13:57:06 +0100, Daniel Vetter > wrote: > > ... like for forcewake, which protects everything _but_ display. > > Expect more things (like gtt abstractions, rings, inter-ring sync) > > to come. > > The only thing t

Re: [Intel-gfx] [PATCH 09/43] drm/i915: introduce a vtable for gpu core functions

2011-12-14 Thread Kenneth Graunke
On 12/14/2011 04:57 AM, Daniel Vetter wrote: > ... like for forcewake, which protects everything _but_ display. > Expect more things (like gtt abstractions, rings, inter-ring sync) > to come. > > Signed-Off-by: Daniel Vetter > Reviewed-by: Eugeni Dodonov > --- > drivers/gpu/drm/i915/i915_drv.c

Re: [Intel-gfx] [PATCH 09/43] drm/i915: introduce a vtable for gpu core functions

2011-12-14 Thread Chris Wilson
On Wed, 14 Dec 2011 13:57:06 +0100, Daniel Vetter wrote: > ... like for forcewake, which protects everything _but_ display. > Expect more things (like gtt abstractions, rings, inter-ring sync) > to come. The only thing that looks odd is the layout in drm_i915_private is a little haphazard. Other

[Intel-gfx] [PATCH 09/43] drm/i915: introduce a vtable for gpu core functions

2011-12-14 Thread Daniel Vetter
... like for forcewake, which protects everything _but_ display. Expect more things (like gtt abstractions, rings, inter-ring sync) to come. Signed-Off-by: Daniel Vetter Reviewed-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_drv.c |6 +++--- drivers/gpu/drm/i915/i915_drv.h |