Re: [Intel-gfx] [PATCH 09/33] drm/i915: VGACNTRL needs an offset on VLV

2013-01-25 Thread Ville Syrjälä
On Fri, Jan 25, 2013 at 05:00:42PM +0100, Daniel Vetter wrote: > On Fri, Jan 25, 2013 at 02:21:16PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 24, 2013 at 10:39:52PM +0100, Daniel Vetter wrote: > > > On Thu, Jan 24, 2013 at 03:29:34PM +0200, ville.syrj...@linux.intel.com > > > wrote: > > > > From

Re: [Intel-gfx] [PATCH 09/33] drm/i915: VGACNTRL needs an offset on VLV

2013-01-25 Thread Daniel Vetter
On Fri, Jan 25, 2013 at 02:21:16PM +0200, Ville Syrjälä wrote: > On Thu, Jan 24, 2013 at 10:39:52PM +0100, Daniel Vetter wrote: > > On Thu, Jan 24, 2013 at 03:29:34PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Signed-off-by: Ville Syrjälä > > > > We a

Re: [Intel-gfx] [PATCH 09/33] drm/i915: VGACNTRL needs an offset on VLV

2013-01-25 Thread Ville Syrjälä
On Thu, Jan 24, 2013 at 10:39:52PM +0100, Daniel Vetter wrote: > On Thu, Jan 24, 2013 at 03:29:34PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Signed-off-by: Ville Syrjälä > > We already have a switch since VGACNTRL moved around on pch-split > platforms, too. To

Re: [Intel-gfx] [PATCH 09/33] drm/i915: VGACNTRL needs an offset on VLV

2013-01-24 Thread Daniel Vetter
On Thu, Jan 24, 2013 at 03:29:34PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä We already have a switch since VGACNTRL moved around on pch-split platforms, too. To avoid confusion with different ways to select a given reg I think a static i

[Intel-gfx] [PATCH 09/33] drm/i915: VGACNTRL needs an offset on VLV

2013-01-24 Thread ville . syrjala
From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 87eed0c..8b581b5 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/dr