Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-18 Thread Rodrigo Vivi
On Thu, Jul 18, 2013 at 5:24 AM, Daniel Vetter wrote: > On Wed, Jul 17, 2013 at 10:08:34PM +0100, Chris Wilson wrote: >> On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote: >> > On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson >> > wrote: >> > > On Wed, Jul 17, 2013 at 02:46:52PM -0300, R

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-18 Thread Daniel Vetter
On Wed, Jul 17, 2013 at 10:08:34PM +0100, Chris Wilson wrote: > On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote: > > On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson > > wrote: > > > On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: > > >> Hi Chris, > > >> > > >> could you p

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-17 Thread Chris Wilson
On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote: > On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson > wrote: > > On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: > >> Hi Chris, > >> > >> could you please review this specific one or give you ack here? > > > > Didn't see anyt

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-17 Thread Rodrigo Vivi
On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson wrote: > On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: >> Hi Chris, >> >> could you please review this specific one or give you ack here? > > Didn't see anything wrong with it. The only caveat I have is that the > GETPARAM must be accur

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-17 Thread Chris Wilson
On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: > Hi Chris, > > could you please review this specific one or give you ack here? Didn't see anything wrong with it. The only caveat I have is that the GETPARAM must be accurate immediately following a setcrtc. If you can guarrantee that

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-17 Thread Rodrigo Vivi
Hi Chris, could you please review this specific one or give you ack here? Thanks On Thu, Jul 11, 2013 at 6:45 PM, Rodrigo Vivi wrote: > This global value allows userspace know when PSR is enabled. > > This will allow userspace emit more busy_ioctl when doing directly copy_area > operations thro

[Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-11 Thread Rodrigo Vivi
This global value allows userspace know when PSR is enabled. This will allow userspace emit more busy_ioctl when doing directly copy_area operations through scanout allowing forced psr exit. v2: Check for PSR enabled instead of active. (by Chris Wilson) v3: Use existing intel_edp_is_psr_enabled f