Re: [Intel-gfx] [PATCH 08/24] drm/i915: fix hpd interrupt register locking

2013-06-12 Thread Daniel Vetter
On Wed, Jun 12, 2013 at 4:59 PM, Egbert Eich wrote: > > +assert_spin_locked(&dev_priv->irq_lock); > > + > > if (I915_HAS_HOTPLUG(dev)) { > > hotplug_en = I915_READ(PORT_HOTPLUG_EN); > > hotplug_en &= ~HOTPLUG_INT_EN_MASK; > > > Didn't you want to do the same

Re: [Intel-gfx] [PATCH 08/24] drm/i915: fix hpd interrupt register locking

2013-06-12 Thread Egbert Eich
Daniel Vetter writes: > Our interrupt handler (in hardird context) could race with the timer Nitpick: s/d/q/ > (in softirq context), hence we need to hold the spinlock around the > call to ->hdp_irq_setup in intel_hpd_irq_handler, too. > > But as an optimization (an

[Intel-gfx] [PATCH 08/24] drm/i915: fix hpd interrupt register locking

2013-06-12 Thread Daniel Vetter
Our interrupt handler (in hardird context) could race with the timer (in softirq context), hence we need to hold the spinlock around the call to ->hdp_irq_setup in intel_hpd_irq_handler, too. But as an optimization (and more so to clarify things) we don't need to do the irqsave/restore dance in th