Re: [Intel-gfx] [PATCH 08/10] drm/i915: Cancel non-persistent contexts on close

2019-10-11 Thread Chris Wilson
Quoting Chris Wilson (2019-10-11 15:22:17) > Quoting Tvrtko Ursulin (2019-10-11 14:55:00) > > > > On 10/10/2019 08:14, Chris Wilson wrote: > > > + if (engine) > > > + active |= engine->mask; > > > + > > > + dma_fence_put(fence); > > > + } > > > + > >

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Cancel non-persistent contexts on close

2019-10-11 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-11 14:55:00) > > On 10/10/2019 08:14, Chris Wilson wrote: > > Normally, we rely on our hangcheck to prevent persistent batches from > > hogging the GPU. However, if the user disables hangcheck, this mechanism > > breaks down. Despite our insistence that this is unsa

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Cancel non-persistent contexts on close

2019-10-11 Thread Tvrtko Ursulin
On 10/10/2019 08:14, Chris Wilson wrote: Normally, we rely on our hangcheck to prevent persistent batches from hogging the GPU. However, if the user disables hangcheck, this mechanism breaks down. Despite our insistence that this is unsafe, the users are equally insistent that they want to use e

[Intel-gfx] [PATCH 08/10] drm/i915: Cancel non-persistent contexts on close

2019-10-10 Thread Chris Wilson
Normally, we rely on our hangcheck to prevent persistent batches from hogging the GPU. However, if the user disables hangcheck, this mechanism breaks down. Despite our insistence that this is unsafe, the users are equally insistent that they want to use endless batches and will disable the hangchec