Re: [Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

Hi Mahesh, Thank you for the patch. On Thursday, 12 July 2018 11:36:33 EEST Mahesh Kumar wrote: > This patch make changes to allocate crc-entries buffer before > enabling CRC generation. > It moves all the failure check early in the function before setting > the source or memory allocation. > Now

[Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source. Ch

[Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source. Ch

Re: [Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

Hi, Thanks for the review. On 7/10/2018 5:19 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:27 EEST Mahesh Kumar wrote: This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in

Re: [Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:27 EEST Mahesh Kumar wrote: > This patch make changes to allocate crc-entries buffer before > enabling CRC generation. > It moves all the failure check early in the function before setting > the source or memory allocation. > Now se

Re: [Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

On 2018-07-02 07:07 AM, Mahesh Kumar wrote: This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt w

[Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source. Si