Re: [Intel-gfx] [PATCH 07/18] drm/mga200g: Hold a proper reference for cursor_set

2015-08-10 Thread Thierry Reding
On Thu, Jul 09, 2015 at 11:32:39PM +0200, Daniel Vetter wrote: > Looking up an obj, immediate dropping the acquired reference and then > continuing to use it isn't how this is supposed to work. Fix this by > holding a reference for the entire function. > > While at it stop grabbing dev->struct_mut

[Intel-gfx] [PATCH 07/18] drm/mga200g: Hold a proper reference for cursor_set

2015-07-09 Thread Daniel Vetter
Looking up an obj, immediate dropping the acquired reference and then continuing to use it isn't how this is supposed to work. Fix this by holding a reference for the entire function. While at it stop grabbing dev->struct_mutex, it doesn't protect anything here. Signed-off-by: Daniel Vetter ---