Re: [Intel-gfx] [PATCH 06/26] drm/fb_helper: set info->par in fill_info()

2019-01-25 Thread Sam Ravnborg
On Fri, Jan 25, 2019 at 09:44:06AM +0100, Daniel Vetter wrote: > On Thu, Jan 24, 2019 at 06:45:52PM +0100, Sam Ravnborg wrote: > > Hi Daniel. > > > > On Thu, Jan 24, 2019 at 05:58:11PM +0100, Daniel Vetter wrote: > > > The fbdev emulation helpers pretty much assume that this is set. > > > Let's do

Re: [Intel-gfx] [PATCH 06/26] drm/fb_helper: set info->par in fill_info()

2019-01-25 Thread Daniel Vetter
On Thu, Jan 24, 2019 at 06:45:52PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > On Thu, Jan 24, 2019 at 05:58:11PM +0100, Daniel Vetter wrote: > > The fbdev emulation helpers pretty much assume that this is set. > > Let's do it for everyone. > > I do not know this code at all. > But I failed to fo

Re: [Intel-gfx] [PATCH 06/26] drm/fb_helper: set info->par in fill_info()

2019-01-24 Thread Sam Ravnborg
Hi Daniel. On Thu, Jan 24, 2019 at 05:58:11PM +0100, Daniel Vetter wrote: > The fbdev emulation helpers pretty much assume that this is set. > Let's do it for everyone. I do not know this code at all. But I failed to follow the code from the patch description. It do not give _me_ a clue why the

[Intel-gfx] [PATCH 06/26] drm/fb_helper: set info->par in fill_info()

2019-01-24 Thread Daniel Vetter
The fbdev emulation helpers pretty much assume that this is set. Let's do it for everyone. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index