Re: [Intel-gfx] [PATCH 06/22] drm/bridge: Use drm_mode_copy()

2022-02-18 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Fri, Feb 18, 2022 at 12:03:47PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > struct drm_display_mode embeds a list head, so overwriting > the full struct with another one will corrupt the list > (if the destination mode is on a list). Use drm_mode_

Re: [Intel-gfx] [PATCH 06/22] drm/bridge: Use drm_mode_copy()

2022-02-18 Thread Andrzej Hajda
On 18.02.2022 11:03, Ville Syrjala wrote: From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the

[Intel-gfx] [PATCH 06/22] drm/bridge: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat