Re: [Intel-gfx] [PATCH 06/14] drm/i915: Validate VBT header before trusting it

2014-04-25 Thread Kumar, Shobhit
On 4/25/2014 2:58 PM, Chris Wilson wrote: On Fri, Apr 25, 2014 at 11:12:06AM +0200, Daniel Vetter wrote: On Fri, Apr 25, 2014 at 01:54:06PM +0530, Kumar, Shobhit wrote: On 4/25/2014 1:32 PM, Daniel Vetter wrote: I will then push a new patch on version check. I've figured Chris could do it, bu

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Validate VBT header before trusting it

2014-04-25 Thread Chris Wilson
On Fri, Apr 25, 2014 at 11:12:06AM +0200, Daniel Vetter wrote: > On Fri, Apr 25, 2014 at 01:54:06PM +0530, Kumar, Shobhit wrote: > > On 4/25/2014 1:32 PM, Daniel Vetter wrote: > > I will then push a new patch on version check. > > I've figured Chris could do it, but if you can take this over I don

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Validate VBT header before trusting it

2014-04-25 Thread Daniel Vetter
On Fri, Apr 25, 2014 at 01:54:06PM +0530, Kumar, Shobhit wrote: > On 4/25/2014 1:32 PM, Daniel Vetter wrote: > >On Thu, Apr 24, 2014 at 09:22:23PM +0530, Kumar, Shobhit wrote: > >>On 4/19/2014 2:34 AM, Rodrigo Vivi wrote: > >>>From: Chris Wilson > >>> > >>>Be we read and chase pointers from the VB

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Validate VBT header before trusting it

2014-04-25 Thread Kumar, Shobhit
On 4/25/2014 1:32 PM, Daniel Vetter wrote: On Thu, Apr 24, 2014 at 09:22:23PM +0530, Kumar, Shobhit wrote: On 4/19/2014 2:34 AM, Rodrigo Vivi wrote: From: Chris Wilson Be we read and chase pointers from the VBT, it is prudent to make sure that those accesses are wholly contained within the MM

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Validate VBT header before trusting it

2014-04-25 Thread Daniel Vetter
On Thu, Apr 24, 2014 at 09:22:23PM +0530, Kumar, Shobhit wrote: > On 4/19/2014 2:34 AM, Rodrigo Vivi wrote: > >From: Chris Wilson > > > >Be we read and chase pointers from the VBT, it is prudent to make sure > >that those accesses are wholly contained within the MMIO region, or else > >we may caus

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Validate VBT header before trusting it

2014-04-24 Thread Kumar, Shobhit
On 4/19/2014 2:34 AM, Rodrigo Vivi wrote: From: Chris Wilson Be we read and chase pointers from the VBT, it is prudent to make sure that those accesses are wholly contained within the MMIO region, or else we may cause a kernel panic during boot. Signed-off-by: Chris Wilson Signed-off-by: Rodr

[Intel-gfx] [PATCH 06/14] drm/i915: Validate VBT header before trusting it

2014-04-18 Thread Rodrigo Vivi
From: Chris Wilson Be we read and chase pointers from the VBT, it is prudent to make sure that those accesses are wholly contained within the MMIO region, or else we may cause a kernel panic during boot. Signed-off-by: Chris Wilson Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_bi