Re: [Intel-gfx] [PATCH 06/14] drm/i915: Cancel retire_worker on parking

2019-05-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-02 15:20:52) > > On 02/05/2019 14:33, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-05-02 14:29:50) > >> > >> On 01/05/2019 12:45, Chris Wilson wrote: > >>> Replace the racy continuation check within retire_work with a definite > >>> kill-switch on idling. Th

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Cancel retire_worker on parking

2019-05-02 Thread Tvrtko Ursulin
On 02/05/2019 14:33, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-02 14:29:50) On 01/05/2019 12:45, Chris Wilson wrote: Replace the racy continuation check within retire_work with a definite kill-switch on idling. The race was being exposed by gem_concurrent_blit where the retire_worke

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Cancel retire_worker on parking

2019-05-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-02 14:29:50) > > On 01/05/2019 12:45, Chris Wilson wrote: > > Replace the racy continuation check within retire_work with a definite > > kill-switch on idling. The race was being exposed by gem_concurrent_blit > > where the retire_worker would be terminated too earl

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Cancel retire_worker on parking

2019-05-02 Thread Tvrtko Ursulin
On 01/05/2019 12:45, Chris Wilson wrote: Replace the racy continuation check within retire_work with a definite kill-switch on idling. The race was being exposed by gem_concurrent_blit where the retire_worker would be terminated too early leaving us spinning in debugfs/i915_drop_caches with noth

[Intel-gfx] [PATCH 06/14] drm/i915: Cancel retire_worker on parking

2019-05-01 Thread Chris Wilson
Replace the racy continuation check within retire_work with a definite kill-switch on idling. The race was being exposed by gem_concurrent_blit where the retire_worker would be terminated too early leaving us spinning in debugfs/i915_drop_caches with nothing flushing the retirement queue. Although