[Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-04-29 Thread Ben Widawsky
Semaphore signalling works similarly to previous GENs with the exception that the per ring mailboxes no longer exist. Instead you must define your own space, somewhere in the GTT. The comments in the code define the layout I've opted for, which should be fairly future proof. Ie. I tried to define

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-03-05 Thread Ville Syrjälä
On Mon, Feb 24, 2014 at 03:10:26PM +0200, Ville Syrjälä wrote: > On Wed, Feb 19, 2014 at 10:19:19PM -0800, Ben Widawsky wrote: > > > @@ -634,6 +641,85 @@ static void render_ring_cleanup(struct > > intel_ring_buffer *ring) > > ring->scratch.obj = NULL; > > } > > > > +static int gen8_rcs_sig

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-24 Thread Ville Syrjälä
On Wed, Feb 19, 2014 at 10:19:19PM -0800, Ben Widawsky wrote: > @@ -634,6 +641,85 @@ static void render_ring_cleanup(struct intel_ring_buffer > *ring) > ring->scratch.obj = NULL; > } > > +static int gen8_rcs_signal(struct intel_ring_buffer *signaller, > +unsigned

[Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-19 Thread Ben Widawsky
Semaphore signalling works similarly to previous GENs with the exception that the per ring mailboxes no longer exist. Instead you must define your own space, somewhere in the GTT. The comments in the code define the layout I've opted for, which should be fairly future proof. Ie. I tried to define

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-12 Thread Ville Syrjälä
On Tue, Feb 11, 2014 at 03:01:31PM -0800, Ben Widawsky wrote: > On Tue, Feb 11, 2014 at 02:22:37PM -0800, Ben Widawsky wrote: > > On Tue, Feb 11, 2014 at 02:11:04PM -0800, Ben Widawsky wrote: > > > On Thu, Jan 30, 2014 at 02:38:17PM +0200, Ville Syrjälä wrote: > > > > On Wed, Jan 29, 2014 at 11:55:

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-11 Thread Ben Widawsky
On Tue, Feb 11, 2014 at 02:22:37PM -0800, Ben Widawsky wrote: > On Tue, Feb 11, 2014 at 02:11:04PM -0800, Ben Widawsky wrote: > > On Thu, Jan 30, 2014 at 02:38:17PM +0200, Ville Syrjälä wrote: > > > On Wed, Jan 29, 2014 at 11:55:26AM -0800, Ben Widawsky wrote: > > > > Semaphore signalling works sim

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-11 Thread Chris Wilson
On Tue, Feb 11, 2014 at 02:25:43PM -0800, Ben Widawsky wrote: > On Tue, Feb 11, 2014 at 10:23:38PM +, Chris Wilson wrote: > > Gut feeling is that it fixes an issue with IVB TLB invalidate. > > (Not yet sure if the bug I was looking at was accidentally fixed at the > > same time as testing this.

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-11 Thread Ben Widawsky
On Tue, Feb 11, 2014 at 10:23:38PM +, Chris Wilson wrote: > On Tue, Feb 11, 2014 at 01:48:22PM -0800, Ben Widawsky wrote: > > On Thu, Jan 30, 2014 at 01:35:41PM +, Chris Wilson wrote: > > > On Thu, Jan 30, 2014 at 02:18:32PM +0100, Daniel Vetter wrote: > > > > On Thu, Jan 30, 2014 at 1:46 P

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-11 Thread Chris Wilson
On Tue, Feb 11, 2014 at 01:48:22PM -0800, Ben Widawsky wrote: > On Thu, Jan 30, 2014 at 01:35:41PM +, Chris Wilson wrote: > > On Thu, Jan 30, 2014 at 02:18:32PM +0100, Daniel Vetter wrote: > > > On Thu, Jan 30, 2014 at 1:46 PM, Chris Wilson > > > wrote: > > > > Oh. So they changed how post-sy

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-11 Thread Ben Widawsky
On Tue, Feb 11, 2014 at 02:11:04PM -0800, Ben Widawsky wrote: > On Thu, Jan 30, 2014 at 02:38:17PM +0200, Ville Syrjälä wrote: > > On Wed, Jan 29, 2014 at 11:55:26AM -0800, Ben Widawsky wrote: > > > Semaphore signalling works similarly to previous GENs with the exception > > > that the per ring mai

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-11 Thread Ben Widawsky
On Thu, Jan 30, 2014 at 02:38:17PM +0200, Ville Syrjälä wrote: > On Wed, Jan 29, 2014 at 11:55:26AM -0800, Ben Widawsky wrote: > > Semaphore signalling works similarly to previous GENs with the exception > > that the per ring mailboxes no longer exist. Instead you must define > > your own space, so

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-02-11 Thread Ben Widawsky
On Thu, Jan 30, 2014 at 01:35:41PM +, Chris Wilson wrote: > On Thu, Jan 30, 2014 at 02:18:32PM +0100, Daniel Vetter wrote: > > On Thu, Jan 30, 2014 at 1:46 PM, Chris Wilson > > wrote: > > > Oh. So they changed how post-sync writes operated - this should be a > > > separate fix for stable I be

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-01-30 Thread Chris Wilson
On Thu, Jan 30, 2014 at 02:18:32PM +0100, Daniel Vetter wrote: > On Thu, Jan 30, 2014 at 1:46 PM, Chris Wilson > wrote: > > Oh. So they changed how post-sync writes operated - this should be a > > separate fix for stable I believe (so that batches are not run before we > > have finished invalidat

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-01-30 Thread Chris Wilson
On Thu, Jan 30, 2014 at 02:18:32PM +0100, Daniel Vetter wrote: > On Thu, Jan 30, 2014 at 1:46 PM, Chris Wilson > wrote: > > Oh. So they changed how post-sync writes operated - this should be a > > separate fix for stable I believe (so that batches are not run before we > > have finished invalidat

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-01-30 Thread Daniel Vetter
On Thu, Jan 30, 2014 at 1:46 PM, Chris Wilson wrote: > Oh. So they changed how post-sync writes operated - this should be a > separate fix for stable I believe (so that batches are not run before we > have finished invalidating the TLBs required). We have an igt to exercise tlb invalidation stuff

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-01-30 Thread Chris Wilson
On Thu, Jan 30, 2014 at 02:38:17PM +0200, Ville Syrjälä wrote: > On Wed, Jan 29, 2014 at 11:55:26AM -0800, Ben Widawsky wrote: > > Semaphore signalling works similarly to previous GENs with the exception > > that the per ring mailboxes no longer exist. Instead you must define > > your own space, so

Re: [Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-01-30 Thread Ville Syrjälä
On Wed, Jan 29, 2014 at 11:55:26AM -0800, Ben Widawsky wrote: > Semaphore signalling works similarly to previous GENs with the exception > that the per ring mailboxes no longer exist. Instead you must define > your own space, somewhere in the GTT. > > The comments in the code define the layout I'v

[Intel-gfx] [PATCH 06/13] drm/i915/bdw: implement semaphore signal

2014-01-29 Thread Ben Widawsky
Semaphore signalling works similarly to previous GENs with the exception that the per ring mailboxes no longer exist. Instead you must define your own space, somewhere in the GTT. The comments in the code define the layout I've opted for, which should be fairly future proof. Ie. I tried to define