Re: [Intel-gfx] [PATCH 06/11] drm/i915/gtt: Convert vm->scratch into an array

2019-07-10 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-07-10 15:18:32) >> Chris Wilson writes: >> > - if (i915_vm_is_4lvl(vm)) { >> > - if (unlikely(setup_page_dma(vm, &vm->scratch_pdp))) { >> > - ret = -ENOMEM; >> > - goto free_pd; >> > -

Re: [Intel-gfx] [PATCH 06/11] drm/i915/gtt: Convert vm->scratch into an array

2019-07-10 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-10 15:18:32) > Chris Wilson writes: > > - if (i915_vm_is_4lvl(vm)) { > > - if (unlikely(setup_page_dma(vm, &vm->scratch_pdp))) { > > - ret = -ENOMEM; > > - goto free_pd; > > - } > > - fil

Re: [Intel-gfx] [PATCH 06/11] drm/i915/gtt: Convert vm->scratch into an array

2019-07-10 Thread Mika Kuoppala
Chris Wilson writes: > Each level has its own scratch. Make the levels more obvious by forgoing > the fancy similarly names and replace them with a number. 0 is the bottom > most level, the physical page used for actual data; 1+ are the page > directories. > > Signed-off-by: Chris Wilson > --- >

[Intel-gfx] [PATCH 06/11] drm/i915/gtt: Convert vm->scratch into an array

2019-07-07 Thread Chris Wilson
Each level has its own scratch. Make the levels more obvious by forgoing the fancy similarly names and replace them with a number. 0 is the bottom most level, the physical page used for actual data; 1+ are the page directories. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c