Re: [Intel-gfx] [PATCH 06/10] drm/i915/spi: spi register with mtd

2023-11-14 Thread Miquel Raynal
Hi Alexander, + Michael and Tudor Folks, any interesting thought about the below discussion? alexander.usys...@intel.com wrote on Tue, 14 Nov 2023 08:47:34 +: > > > > > > > > > + spi->mtd.writesize = SZ_1; /* 1 byte granularity */ > > > > > > > > > > > > You say writesize should be ali

Re: [Intel-gfx] [PATCH 06/10] drm/i915/spi: spi register with mtd

2023-11-14 Thread Usyskin, Alexander
> > > > > > > + spi->mtd.writesize = SZ_1; /* 1 byte granularity */ > > > > > > > > > > You say writesize should be aligned with 4 in your next patch? > > > > > > > > We support unaligned write by reading aligned 4bytes, > > > > replacing changed bytes there and writing whole 4bytes back. > > >

Re: [Intel-gfx] [PATCH 06/10] drm/i915/spi: spi register with mtd

2023-10-17 Thread Miquel Raynal
Hi Alexander, alexander.usys...@intel.com wrote on Tue, 17 Oct 2023 14:20:32 +: > > > > > + spi->mtd.writesize = SZ_1; /* 1 byte granularity */ > > > > > > > > You say writesize should be aligned with 4 in your next patch? > > > > > > We support unaligned write by reading aligned 4byt

Re: [Intel-gfx] [PATCH 06/10] drm/i915/spi: spi register with mtd

2023-10-17 Thread Usyskin, Alexander
> > > > + spi->mtd.writesize = SZ_1; /* 1 byte granularity */ > > > > > > You say writesize should be aligned with 4 in your next patch? > > > > We support unaligned write by reading aligned 4bytes, > > replacing changed bytes there and writing whole 4bytes back. > > Is there any problem with

Re: [Intel-gfx] [PATCH 06/10] drm/i915/spi: spi register with mtd

2023-10-17 Thread Miquel Raynal
Hi Alexander, alexander.usys...@intel.com wrote on Tue, 17 Oct 2023 11:54:41 +: > Hi Miquel, > > > > +static int i915_spi_init_mtd(struct i915_spi *spi, struct device *device, > > > + unsigned int nparts) > > > +{ > > > + unsigned int i; > > > + unsigned int n; > > > +

Re: [Intel-gfx] [PATCH 06/10] drm/i915/spi: spi register with mtd

2023-10-17 Thread Usyskin, Alexander
Hi Miquel, > > +static int i915_spi_init_mtd(struct i915_spi *spi, struct device *device, > > +unsigned int nparts) > > +{ > > + unsigned int i; > > + unsigned int n; > > + struct mtd_partition *parts = NULL; > > + int ret; > > + > > + dev_dbg(device, "registerin

Re: [Intel-gfx] [PATCH 06/10] drm/i915/spi: spi register with mtd

2023-10-16 Thread Miquel Raynal
Hi Alexander, > +static int i915_spi_init_mtd(struct i915_spi *spi, struct device *device, > + unsigned int nparts) > +{ > + unsigned int i; > + unsigned int n; > + struct mtd_partition *parts = NULL; > + int ret; > + > + dev_dbg(device, "registering wi

[Intel-gfx] [PATCH 06/10] drm/i915/spi: spi register with mtd

2023-09-10 Thread Alexander Usyskin
From: Tomas Winkler Register the on-die spi device with the mtd subsystem. Refcount spi object on _get and _put mtd callbacks. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi_drv.c | 118 ++