Re: [Intel-gfx] [PATCH 05/17] drm: Add atomic driver interface definitions for objects

2014-11-05 Thread Damien Lespiau
On Wed, Nov 05, 2014 at 06:04:59PM +0100, Daniel Vetter wrote: > On Wed, Nov 5, 2014 at 5:26 PM, Thierry Reding > wrote: > >> +struct drm_plane_state { > >> + struct drm_crtc *crtc; > >> + struct drm_framebuffer *fb; > >> + > >> + /* Signed dest location allows it to be partially off

Re: [Intel-gfx] [PATCH 05/17] drm: Add atomic driver interface definitions for objects

2014-11-05 Thread Daniel Vetter
On Wed, Nov 5, 2014 at 5:26 PM, Thierry Reding wrote: >> +struct drm_plane_state { >> + struct drm_crtc *crtc; >> + struct drm_framebuffer *fb; >> + >> + /* Signed dest location allows it to be partially off screen */ >> + int32_t crtc_x, crtc_y; >> + uint32_t crtc_w, crtc_h; >

Re: [Intel-gfx] [PATCH 05/17] drm: Add atomic driver interface definitions for objects

2014-11-05 Thread Thierry Reding
On Sun, Nov 02, 2014 at 02:19:18PM +0100, Daniel Vetter wrote: [...] > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index a68e02be7e37..9847009ad451 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -224,6 +224,25 @@ struct drm_encoder; > struct drm_pendin

Re: [Intel-gfx] [PATCH 05/17] drm: Add atomic driver interface definitions for objects

2014-11-04 Thread Sean Paul
On Sun, Nov 02, 2014 at 02:19:18PM +0100, Daniel Vetter wrote: > Heavily based upon Rob Clark's atomic series. > - Dropped the connctor state from the crtc state, instead opting for a nit: s/connctor/connector/ > full-blown connector state. The only thing it has is the desired > crtc, but dri

[Intel-gfx] [PATCH 05/17] drm: Add atomic driver interface definitions for objects

2014-11-02 Thread Daniel Vetter
Heavily based upon Rob Clark's atomic series. - Dropped the connctor state from the crtc state, instead opting for a full-blown connector state. The only thing it has is the desired crtc, but drivers which have connector properties have now a data-structure to subclass. - Rename create_state