Re: [Intel-gfx] [PATCH 05/17] drm/i915: Move ring_begin to signal()

2013-12-14 Thread Ben Widawsky
On Sat, Dec 14, 2013 at 09:05:03AM +, Chris Wilson wrote: > On Fri, Dec 13, 2013 at 08:15:53PM -0800, Ben Widawsky wrote: > > Add_request has always contained both the semaphore mailbox updates as > > well as the breadcrumb writes. Since the semaphore signal is the one > > which actually knows

Re: [Intel-gfx] [PATCH 05/17] drm/i915: Move ring_begin to signal()

2013-12-14 Thread Chris Wilson
On Fri, Dec 13, 2013 at 08:15:53PM -0800, Ben Widawsky wrote: > Add_request has always contained both the semaphore mailbox updates as > well as the breadcrumb writes. Since the semaphore signal is the one > which actually knows about the number of dwords it needs to emit to the > ring, we move the

[Intel-gfx] [PATCH 05/17] drm/i915: Move ring_begin to signal()

2013-12-13 Thread Ben Widawsky
Add_request has always contained both the semaphore mailbox updates as well as the breadcrumb writes. Since the semaphore signal is the one which actually knows about the number of dwords it needs to emit to the ring, we move the ring_begin to that function. This allows us to remove the hideously s